diff options
context:
space:
mode:
Diffstat (limited to 'source')
-rw-r--r--source/ui-shared.c30
-rw-r--r--source/ui-tree.c7
2 files changed, 22 insertions, 15 deletions
diff --git a/source/ui-shared.c b/source/ui-shared.c
index 05fa30b..02352bf 100644
--- a/source/ui-shared.c
+++ b/source/ui-shared.c
@@ -1032,7 +1032,8 @@ void cgit_submodule_link(const char *class, char *path, const char *rev)
{
struct string_list *list;
struct string_list_item *item;
- char tail, *dir;
+ char tail;
+ const char *name;
size_t len;
len = 0;
@@ -1047,6 +1048,12 @@ void cgit_submodule_link(const char *class, char *path, const char *rev)
item = lookup_path(list, path);
}
}
+
+ // The row shows the entry's own name, like every other row, while
+ // the lookups above want the full path.
+ name = strrchr(path, '/');
+ name = name ? name + 1 : path;
+
if (item || ctx.repo->module_link) {
html("<a ");
if (class)
@@ -1056,29 +1063,26 @@ void cgit_submodule_link(const char *class, char *path, const char *rev)
const char *args[] = { rev };
emit_module_link(item->util, args, 1);
} else {
- const char *args[2];
- dir = strrchr(path, '/');
- if (dir)
- dir++;
- else
- dir = path;
- args[0] = dir;
- args[1] = rev;
+ const char *args[] = { name, rev };
emit_module_link(ctx.repo->module_link, args, 2);
}
html("'>");
- html_txt(path);
+ html_txt(name);
html("</a>");
} else {
html("<span");
if (class)
htmlf(" class='%s'", class);
html(">");
- html_txt(path);
+ html_txt(name);
html("</span>");
}
- html_txtf(" @ %.7s", rev);
- if (item && tail)
+ html(" @ <span class='ls-mod-hash' title='");
+ html_attr(rev);
+ html("'>");
+ html_txtf("%.7s", rev);
+ html("</span>");
+ if (tail == '/')
path[len - 1] = tail;
}
diff --git a/source/ui-tree.c b/source/ui-tree.c
index cf3938e..ce57f92 100644
--- a/source/ui-tree.c
+++ b/source/ui-tree.c
@@ -333,7 +333,10 @@ static void print_ls_row(const struct object_id *oid, const char *pathname,
free(buf);
strbuf_release(&linkpath);
}
- htmlf("</td><td class='ls-size'>%lu</td>", size);
+ if (S_ISGITLINK(mode))
+ html("</td><td class='ls-size'>-</td>");
+ else
+ htmlf("</td><td class='ls-size'>%lu</td>", size);
html("<td class='ls-links'>");
cgit_log_link("log", NULL, "button", ctx.qry.head,
@@ -345,7 +348,7 @@ static void print_ls_row(const struct object_id *oid, const char *pathname,
if (!S_ISGITLINK(mode))
cgit_plain_link("plain", NULL, "button", ctx.qry.head,
walk->rev, fullpath.buf);
- if (!S_ISDIR(mode) && ctx.repo->enable_blame)
+ if (!S_ISDIR(mode) && !S_ISGITLINK(mode) && ctx.repo->enable_blame)
cgit_blame_link("blame", NULL, "button", ctx.qry.head,
walk->rev, fullpath.buf);
html("</td></tr>\n");