3 files changed, 0 insertions, 4 deletions

diff --git a/tests/t0204-limits.sh b/tests/t0204-limits.shindex e6d69bd..1a1d7ad 100755--- a/tests/t0204-limits.sh+++ b/tests/t0204-limits.sh@@ -55,7 +55,6 @@ limitq() { CGIT_CONFIG="$PWD/limitrc" QUERY_STRING="$1" cgit; } # behave any differently. test_expect_success 'an enormous query is clamped, not rejected' ' 	long=$(awk "BEGIN{s=\"\";for(i=0;i<4000;i++)s=s \"a\"; print s}") &&-	test ${#long} -eq 4000 && 	cgit_query "q=$long" >tmp && 	grep "</html>" tmp && 	longest=$(grep -o "aaaa*" tmp | awk "{print length}" | sort -n | tail -1) &&
diff --git a/tests/t0204-limits.sh b/tests/t0204-limits.sh
index e6d69bd..1a1d7ad 100755
--- a/tests/t0204-limits.sh
+++ b/tests/t0204-limits.sh
@@ -55,7 +55,6 @@ limitq() { CGIT_CONFIG="$PWD/limitrc" QUERY_STRING="$1" cgit; }
 # behave any differently.
 test_expect_success 'an enormous query is clamped, not rejected' '
 	long=$(awk "BEGIN{s=\"\";for(i=0;i<4000;i++)s=s \"a\"; print s}") &&
-	test ${#long} -eq 4000 &&
 	cgit_query "q=$long" >tmp &&
 	grep "</html>" tmp &&
 	longest=$(grep -o "aaaa*" tmp | awk "{print length}" | sort -n | tail -1) &&
diff --git a/tests/t0301-security.sh b/tests/t0301-security.shindex 390bed1..be87a2b 100755--- a/tests/t0301-security.sh+++ b/tests/t0301-security.sh@@ -39,7 +39,6 @@ secq() { CGIT_CONFIG="$PWD/seccgitrc" QUERY_STRING="$1" cgit; } # tip, so a request for id=--output=<path> could create or truncate any file # the server is able to write. test_expect_success 'log id=--output does not write a file' '-	rm -f pwned && 	cgit_query "url=foo/log&id=--output=$PWD/pwned" >tmp 2>&1 && 	! test -e pwned '
diff --git a/tests/t0301-security.sh b/tests/t0301-security.sh
index 390bed1..be87a2b 100755
--- a/tests/t0301-security.sh
+++ b/tests/t0301-security.sh
@@ -39,7 +39,6 @@ secq() { CGIT_CONFIG="$PWD/seccgitrc" QUERY_STRING="$1" cgit; }
 # tip, so a request for id=--output=<path> could create or truncate any file
 # the server is able to write.
 test_expect_success 'log id=--output does not write a file' '
-	rm -f pwned &&
 	cgit_query "url=foo/log&id=--output=$PWD/pwned" >tmp 2>&1 &&
 	! test -e pwned
 '
diff --git a/tests/t0303-robustness.sh b/tests/t0303-robustness.shindex ec78cd5..cf49d03 100755--- a/tests/t0303-robustness.sh+++ b/tests/t0303-robustness.sh@@ -470,7 +470,6 @@ test_expect_success 'an indented comment in the mimetype file is skipped' ' '  test_expect_success 'a refs page named with an id is not cached for ever' '-	mkdir -p cache && 	{ 		echo "cache-size=10" && 		echo "cache-root=$PWD/cache" &&@@ -782,7 +781,6 @@ test_expect_success 'a readme past max-blob-size is reported on the about page' # that was just refused must not be looked up to get there, since the wider # revision syntax walks the whole history for a match. test_expect_success 'the error page does not resolve the id it refused' '-	sha=$(git -C repos/rob rev-parse HEAD~1) && 	robq "url=rob/log/&id=$sha" >tmp && 	grep "<title>.* @ " tmp && 	robq "url=rob/log/&id=%3A/commit" >tmp &&
diff --git a/tests/t0303-robustness.sh b/tests/t0303-robustness.sh
index ec78cd5..cf49d03 100755
--- a/tests/t0303-robustness.sh
+++ b/tests/t0303-robustness.sh
@@ -470,7 +470,6 @@ test_expect_success 'an indented comment in the mimetype file is skipped' '
 '
 
 test_expect_success 'a refs page named with an id is not cached for ever' '
-	mkdir -p cache &&
 	{
 		echo "cache-size=10" &&
 		echo "cache-root=$PWD/cache" &&
@@ -782,7 +781,6 @@ test_expect_success 'a readme past max-blob-size is reported on the about page'
 # that was just refused must not be looked up to get there, since the wider
 # revision syntax walks the whole history for a match.
 test_expect_success 'the error page does not resolve the id it refused' '
-	sha=$(git -C repos/rob rev-parse HEAD~1) &&
 	robq "url=rob/log/&id=$sha" >tmp &&
 	grep "<title>.* @ " tmp &&
 	robq "url=rob/log/&id=%3A/commit" >tmp &&