Diff options
| author | Bryce Kwon <bryce@brycekwon.com> | |
|---|---|---|
| committer | Bryce Kwon <bryce@brycekwon.com> | |
| commit | ||
| parent | ||
| tree | ||
| download | ||
Make two branch conditions say what they rely on
cgit_parse_url tested ctx.repo where the loop sets repo_end alongside
it, and the log's closing link kept a commit it never read. The Clang
Static Analyzer tripped on both.
Diffstat (limited to 'source')
| -rw-r--r-- | source/parsing.c | 2 | |
| -rw-r--r-- | source/ui-log.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/source/parsing.c b/source/parsing.c index da09b2b..dab81fa 100644 --- a/source/parsing.c +++ b/source/parsing.c @@ -149,7 +149,7 @@ void cgit_parse_url(const char *url) slash = strchr(slash + 1, '/'); } - if (ctx.repo) { + if (repo_end) { ctx.qry.repo = ctx.repo->url; page_end = strchr(repo_end + 1, '/'); if (page_end) { diff --git a/source/ui-log.c b/source/ui-log.c index 1ac9a77..793f145 100644 --- a/source/ui-log.c +++ b/source/ui-log.c @@ -620,7 +620,7 @@ void cgit_print_log(const char *tip, int ofs, int cnt, char *grep, char *pattern print_pager(&rev, path, ofs, cnt); cgit_print_layout_end(); } else { - if ((commit = get_revision(&rev))) { + if (get_revision(&rev)) { htmlf("<tr class='nohover'><td colspan='%d'>", columns); cgit_log_link( "[...]", NULL, NULL, ctx.qry.head, NULL, ctx.qry.vpath, 0, |