diff options
authorBryce Kwon <bryce@brycekwon.com>
committerBryce Kwon <bryce@brycekwon.com>
commit
parent
tree
download
Keep string literals behind const pointers
Git's DEVELOPER=1 build turns on -Wwrite-strings as an error, and the literals stored through plain char pointers failed cgit's own objects there. The exec filter's argv takes the cast execvp needs once, the way git's run-command does.
Diffstat (limited to 'source/ui-snapshot.c')
-rw-r--r--source/ui-snapshot.c12
1 file changed, 6 insertions, 6 deletions
diff --git a/source/ui-snapshot.c b/source/ui-snapshot.c
index 348fd9c..24d1268 100644
--- a/source/ui-snapshot.c
+++ b/source/ui-snapshot.c
@@ -87,7 +87,7 @@ static int program_on_path(const char *program)
return found;
}
-static int write_compressed_tar_archive(const char *hex, const char *prefix, char *argv[])
+static int write_compressed_tar_archive(const char *hex, const char *prefix, const char *argv[])
{
struct cgit_exec_filter filter;
int result;
@@ -101,28 +101,28 @@ static int write_compressed_tar_archive(const char *hex, const char *prefix, cha
static int write_tar_gzip_archive(const char *hex, const char *prefix)
{
- char *argv[] = { "gzip", "-n", NULL };
+ const char *argv[] = { "gzip", "-n", NULL };
return write_compressed_tar_archive(hex, prefix, argv);
}
static int write_tar_bzip2_archive(const char *hex, const char *prefix)
{
- char *argv[] = { "bzip2", NULL };
+ const char *argv[] = { "bzip2", NULL };
return write_compressed_tar_archive(hex, prefix, argv);
}
static int write_tar_lzip_archive(const char *hex, const char *prefix)
{
- char *argv[] = { "lzip", NULL };
+ const char *argv[] = { "lzip", NULL };
return write_compressed_tar_archive(hex, prefix, argv);
}
static int write_tar_xz_archive(const char *hex, const char *prefix)
{
- char *argv[] = { "xz", NULL };
+ const char *argv[] = { "xz", NULL };
return write_compressed_tar_archive(hex, prefix, argv);
}
@@ -131,7 +131,7 @@ static int write_tar_zstd_archive(const char *hex, const char *prefix)
{
// Single-threaded like the other compressors, since -T0 would let one
// request pin every core.
- char *argv[] = { "zstd", NULL };
+ const char *argv[] = { "zstd", NULL };
return write_compressed_tar_archive(hex, prefix, argv);
}