From d8d7eaeb181cfaab7b49560abdcbbe9342428f07 Mon Sep 17 00:00:00 2001 From: Bryce Kwon Date: Tue, 15 Sep 2026 19:09:13 -1000 Subject: Add the link-trailers extension --- tests/extensions/test-link-trailers.lua | 66 +++++++++++++++++++++++++++++++ tests/t0506-link-trailers.sh | 70 +++++++++++++++++++++++++++++++++ 2 files changed, 136 insertions(+) create mode 100644 tests/extensions/test-link-trailers.lua create mode 100755 tests/t0506-link-trailers.sh (limited to 'tests') diff --git a/tests/extensions/test-link-trailers.lua b/tests/extensions/test-link-trailers.lua new file mode 100644 index 0000000..c879340 --- /dev/null +++ b/tests/extensions/test-link-trailers.lua @@ -0,0 +1,66 @@ +-- Unit checks for custom/extensions/link-trailers.lua, run under a standalone +-- Lua by t0506-link-trailers.sh with the script path as the argument. The +-- shipped configuration links Fixes and Reverts object names to ./?id=, +-- Closes and Bug marks to bugs.example.com and a bare URL to itself, and +-- everything here checks that shape, the key matching and the values that +-- must pass through untouched. + +local test_directory = arg[0]:match("^(.*)/") or "." +local h = dofile(test_directory .. "/harness.lua") + +h.load(arg[1]) + +local function render(key, text) + return h.run({ key, "commit" }, { text }) +end + +local out, ret = render("Fixes", "1234567 (\"plain commit\")") +h.contains("a Fixes object name links to its commit", out, + "1234567 (\"plain commit\")") +h.equals("close answers zero", ret, 0) + +out = render("fixes", "1234567") +h.contains("the key matches case insensitively", out, "1234567") + +out = render("Fixes", "123456") +h.excludes("six hex characters stay text", out, "cafebabe") + +out = render("Closes", "#45") +h.equals("a Closes mark links to the tracker", out, + "#45") + +out = render("Bug", "45") +h.equals("a bare Bug number links to the tracker", out, + "45") + +out = render("Closes", "not a number") +h.equals("a Closes value that is no number stays text", out, "not a number") + +out = render("Link", "https://example.com/?a=1&b=2") +h.equals("a bare URL links to itself with its escaping kept", out, + "https://example.com/?a=1&b=2") + +out = render("Whatever", "https://example.com/x") +h.contains("a URL links under any key", out, "") + +out = render("Link", "https://example.com/it's") +h.equals("a URL holding a quote stays text", out, "https://example.com/it's") + +out = render("Link", "see https://example.com/x") +h.equals("a URL inside other text stays text", out, "see https://example.com/x") + +out = render("Reported-by", "someone") +h.equals("a key with no rule passes through", out, "someone") + +out = h.run({ "Fixes", "commit" }, { "12345", "67 tail" }) +h.contains("a value split across writes is seen whole", out, + "1234567 tail") + +out, ret = render("Fixes", "") +h.equals("an empty value stays empty", out, "") +h.equals("an empty value still answers zero", ret, 0) + +h.finish() diff --git a/tests/t0506-link-trailers.sh b/tests/t0506-link-trailers.sh new file mode 100755 index 0000000..d397309 --- /dev/null +++ b/tests/t0506-link-trailers.sh @@ -0,0 +1,70 @@ +#!/bin/sh + +# Checks link-trailers.lua, the shipped trailer-filter, whose configuration as +# shipped links Fixes and Reverts object names to ./?id=, Closes and Bug marks +# to bugs.example.com and a bare URL to itself. The unit checks cover the rules +# under every suitable standalone Lua, and a commit carrying one of each is +# then rendered through cgit itself. + +test_description='Check the shipped link-trailers extension' +CGIT_TEST_NO_CREATE_REPOS=YesPlease +. ./setup.sh +. "$TEST_OUTPUT_DIRECTORY/extensions/lib.sh" + +interpreters=$(ext_lua_interpreters 4) +test -z "$interpreters" && + say 'no standalone lua on the path, unit checks skipped' + +for lua in $interpreters +do + test_expect_success "unit checks under $lua" " + '$lua' '$EXT_TEST_DIRECTORY/test-link-trailers.lua' '$EXTENSIONS_DIRECTORY/link-trailers.lua' + " +done + +test "$CGIT_HAS_LUA" -eq 1 && test_set_prereq CGIT_LUA +test "$CGIT_HAS_LUA" -eq 1 || + say 'cgit built without lua, filter checks through cgit skipped' + +test_expect_success 'create a repository whose commit carries linkable trailers' ' + test_create_repo repos/linky && + ( + cd repos/linky && + echo content >file && + git add file && + git commit -F - <<-\EOF + fix it + + Fixes: 1234567 ("earlier") + Link: https://example.com/?a=1&b=2 + Closes: #45 + EOF + ) +' + +test_expect_success 'point cgit at it through the trailer filter' ' + cat >cgitrc <<-EOF + virtual-root=/ + cache-size=0 + enable-trailers=1 + enable-filter-overrides=1 + repo.url=linky + repo.path=$PWD/repos/linky/.git + repo.trailer-filter=lua:$EXTENSIONS_DIRECTORY/link-trailers.lua + EOF +' + +test_expect_success CGIT_LUA 'the Fixes object name links to its commit page' ' + cgit_url "linky/commit/" >tmp && + grep "Fixes1234567 (.earlier.)" tmp +' + +test_expect_success CGIT_LUA 'the bare URL links to itself' ' + grep "https://example.com/?a=1&b=2" tmp +' + +test_expect_success CGIT_LUA 'the Closes mark links out' ' + grep "bugs.example.com/?bug=45.>#45" tmp +' + +test_done -- cgit v2.8.0