From a9f2482fa568fcf1505b249d999dc43251ae5120 Mon Sep 17 00:00:00 2001 From: Bryce Kwon Date: Sat, 17 Oct 2026 17:09:16 -1000 Subject: Isolate git from HOME before git's own setup Git reads the global config for its trace settings before cmd_main is reached, so the isolation there came too late and every request probed $HOME/.gitconfig. The home-access test had passed on arm64 only because access is no syscall of its own there, so it now traces every call that takes a path. --- tests/t0302-home-access.sh | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'tests') diff --git a/tests/t0302-home-access.sh b/tests/t0302-home-access.sh index e0da1f2..df55e0d 100755 --- a/tests/t0302-home-access.sh +++ b/tests/t0302-home-access.sh @@ -3,8 +3,9 @@ # Guards the promise that cgit reads nothing out of the home directory of # whichever account the web server happens to run as. Every page is fetched # under strace with HOME pointed at a path that is known not to exist, and -# the run fails if any access call names that path, which is how a stray -# read of a personal gitconfig would show up. +# the run fails if any call taking a path names it, which is how a stray +# read of a personal gitconfig would show up. The whole file class is traced +# rather than access alone, which is no syscall of its own on arm64. test_description='Ensure that git does not access $HOME' . ./setup.sh @@ -39,7 +40,7 @@ test_no_home_access() { -E HOME="$missing_home" \ -E CGIT_CONFIG="$PWD/cgitrc" \ -E QUERY_STRING="url=$1" \ - -e access -f -o strace.out cgit && + -e trace=%file -f -o strace.out cgit && ! grep "$missing_home" strace.out } -- cgit