From 379bcfa15649017fb1c3049bd388f17acc7b7f71 Mon Sep 17 00:00:00 2001 From: Bryce Kwon Date: Sat, 31 Oct 2026 14:13:59 -0700 Subject: Leave two log checks to the log tests t0103 already renders foo/log and finds commit 5, and its search for a bracket fails the same way this literal search did if --fixed-strings ever goes. --- tests/t0301-security.sh | 5 ----- tests/t0303-robustness.sh | 7 ------- 2 files changed, 12 deletions(-) (limited to 'tests') diff --git a/tests/t0301-security.sh b/tests/t0301-security.sh index 966754b..390bed1 100755 --- a/tests/t0301-security.sh +++ b/tests/t0301-security.sh @@ -48,11 +48,6 @@ test_expect_success 'log id=--output is rejected as an invalid revision' ' grep -i "invalid revision" tmp ' -test_expect_success 'a normal log still renders' ' - cgit_query "url=foo/log" >tmp && - grep -i "commit 5" tmp -' - test_expect_success 'a valid id= still renders the log' ' sha=$(git -C repos/foo rev-parse HEAD) && cgit_query "url=foo/log&id=$sha" >tmp && diff --git a/tests/t0303-robustness.sh b/tests/t0303-robustness.sh index 5097b87..bf12dab 100755 --- a/tests/t0303-robustness.sh +++ b/tests/t0303-robustness.sh @@ -335,13 +335,6 @@ test_expect_success 'a revision expression that walks the history is refused' ' grep "^Status: 200" tmp ' -test_expect_success 'the log search is literal' ' - robq "url=rob/log/&qt=grep&q=commit.1" >tmp && - ! grep ">commit 1" tmp && - robq "url=rob/log/&qt=grep&q=commit%201" >tmp && - grep ">commit 1" tmp -' - test_expect_success 'a commit with a broken tree line does not crash the blob page' ' git clone -q repos/rob broken && ( -- cgit