From 2c2d007f33b8bcba23c30057fd8f1224b1b16f1d Mon Sep 17 00:00:00 2001 From: Bryce Kwon Date: Sat, 17 Oct 2026 12:53:17 -1000 Subject: Offer tag snapshots only for a tagged commit The tag page offered a download for a tag of a tree or a blob, which only led to a "Not a commit" page. The refs listing already checks. --- tests/t0113-tag.sh | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'tests') diff --git a/tests/t0113-tag.sh b/tests/t0113-tag.sh index 2c9dc25..ff50f90 100755 --- a/tests/t0113-tag.sh +++ b/tests/t0113-tag.sh @@ -45,4 +45,18 @@ test_expect_success 'a lightweight tag gets the shorter table' ' ! grep "tagged by" tmp ' +# A snapshot is cut from a commit, so a tag of a tree or a blob offers none. +test_expect_success 'a tag of anything but a commit offers no download' ' + git -C repos/foo tag -a -m "a tree" tree-tag HEAD^{tree} && + git -C repos/foo tag blob-tag HEAD:file-1 && + cgit_url "foo/tag/&h=tree-tag" >tmp && + grep "tagged object" tmp && + ! grep ">download<" tmp && + cgit_url "foo/tag/&h=blob-tag" >tmp && + grep "tagged object" tmp && + ! grep ">download<" tmp && + cgit_url "foo/tag/&h=v1.0" >tmp && + grep ">download<" tmp +' + test_done -- cgit