From d472c02274a1a99d0571c7d2f105120d13b0c94d Mon Sep 17 00:00:00 2001 From: Bryce Kwon Date: Sat, 7 Nov 2026 08:37:14 -1000 Subject: Check the Lua-less build through the helpers t0006 ran build/nolua/cgit by its path, so Valgrind never saw it, and its page checks passed a page that logged an error. The Makefile and README said the suite runs both binaries the same way, though only these four tests run the one without Lua. --- tests/valgrind/bin/cgit | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) (limited to 'tests/valgrind') diff --git a/tests/valgrind/bin/cgit b/tests/valgrind/bin/cgit index e5666b5..e50767c 100755 --- a/tests/valgrind/bin/cgit +++ b/tests/valgrind/bin/cgit @@ -6,6 +6,7 @@ # points into the bundled Git tree while CGIT_VALGRIND points back at this # wrapper's home. The tool comes from --valgrind= and its options follow # Git's own wrapper, with any in GIT_VALGRIND_OPTIONS added after them. +# CGIT_VALGRIND_BINARY names a binary to watch other than build/cgit. case "$CGIT_TEST_VALGRIND" in memcheck) tool_options="--leak-check=no --track-origins=yes" @@ -25,4 +26,4 @@ exec "$CGIT_VALGRIND_PROGRAM" -q --error-exitcode=126 \ --log-fd=4 \ --input-fd=4 \ $GIT_VALGRIND_OPTIONS \ - "$CGIT_VALGRIND/../../build/cgit" "$@" + "${CGIT_VALGRIND_BINARY:-$CGIT_VALGRIND/../../build/cgit}" "$@" -- cgit 2.12.1