From 035394e3836fb981c7b0d3e4b72ca745fb56e0ad Mon Sep 17 00:00:00 2001 From: Bryce Kwon Date: Sat, 7 Nov 2026 10:04:02 -1000 Subject: Check the whole page in the extension tests A page that died part way through, or logged an error, passed as long as the text grepped for came before the failure. Four tests also read the page an earlier test had fetched, so none of them could run alone. --- tests/t0503-link-commits.sh | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'tests/t0503-link-commits.sh') diff --git a/tests/t0503-link-commits.sh b/tests/t0503-link-commits.sh index d38093a..06f54dc 100755 --- a/tests/t0503-link-commits.sh +++ b/tests/t0503-link-commits.sh @@ -39,13 +39,14 @@ test_expect_success 'point cgit at it through the commit filter' ' ' test_expect_success CGIT_LUA 'the issue mark stays text on the commit page' ' - cgit_url "linky/commit/" >tmp && - grep "fix #123 near" tmp && - ! grep "bugs.example.com" tmp + cgit_ok_url "linky/commit/" >tmp && + test_grep "fix #123 near" tmp && + test_grep ! "bugs.example.com" tmp ' test_expect_success CGIT_LUA 'the object name links to its own page' ' - grep "id=deadbeefcafe1234.>deadbeefcafe1234" tmp + cgit_ok_url "linky/commit/" >tmp && + test_grep "id=deadbeefcafe1234.>deadbeefcafe1234" tmp ' test_done -- cgit 2.12.1