From 6a45d8c7e9f66d04cf4916264da135def5c0549d Mon Sep 17 00:00:00 2001 From: Bryce Kwon Date: Sat, 7 Nov 2026 19:31:51 -1000 Subject: Add filename* for a download name past ASCII MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The plain, snapshot and blob pages sent a name such as café.txt raw in filename, which a client may read as ISO-8859-1. RFC 6266 has such a name sent again as filename*, percent-encoded in UTF-8, for a client that knows the form, with filename first for one that does not. The extended form carries UTF-8 alone, so a name that is not valid UTF-8 keeps the plain filename by itself. --- tests/t0110-snapshot.sh | 14 ++++++++++++++ 1 file changed, 14 insertions(+) (limited to 'tests/t0110-snapshot.sh') diff --git a/tests/t0110-snapshot.sh b/tests/t0110-snapshot.sh index ded694d..0ada26d 100755 --- a/tests/t0110-snapshot.sh +++ b/tests/t0110-snapshot.sh @@ -430,4 +430,18 @@ test_expect_success 'a signature past max-blob-size is refused' ' cgit_ok sigrc "url=signed/snapshot/signed-one.tar.gz.asc" >tmp ' +# A tag named in UTF-8 gives a snapshot name past ASCII, which is sent as it +# is in filename and percent-encoded in filename*. +test_expect_success 'a snapshot name in UTF-8 is also sent as filename*' ' + mkrepo repos/accent 1 && + tag=$(printf "caf\303\251") && + git -C repos/accent tag "$tag" && + cgitrc_repo accentrc accent snapshots=tar && + cgit_ok accentrc "url=accent/refs/tags" >tmp && + test_grep "accent-$tag.tar" tmp && + cgit_ok accentrc "url=accent/snapshot/accent-caf%C3%A9.tar" >tmp && + sed "/^$/q" tmp >headers && + test_grep "^Content-Disposition: inline; filename=.accent-$tag.tar.; filename\*=UTF-8..accent-caf%C3%A9.tar$" headers +' + test_done -- cgit 2.12.1