From 903b216fb0d7fb7b46d36dd8f81eec815d6a6ce4 Mon Sep 17 00:00:00 2001 From: Bryce Kwon Date: Sat, 17 Oct 2026 17:09:15 -1000 Subject: Abandon a fill whose last flush fails to write The slot being filled was forgotten before the page's final flush, so a write that failed there, on a full disk for one, could not abandon the fill: cgit died into the lock file instead and the visitor got nothing. The mid-page path already delivered the page from the lock file. --- source/cache.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'source') diff --git a/source/cache.c b/source/cache.c index a076823..82b3aad 100644 --- a/source/cache.c +++ b/source/cache.c @@ -370,12 +370,14 @@ static int fill_slot(struct cache_slot *slot) slot_being_filled = slot; slot->fn(); - slot_being_filled = NULL; // All of the page has to reach the lock file before it is renamed - // into place. After an abandoned fill stdout is the client again and + // into place, and a write that fails on this last flush still finds + // the slot to abandon, so the page goes to the visitor rather than + // nowhere. After an abandoned fill stdout is the client again and // this same flush delivers the tail of the error page instead. html_flush(); + slot_being_filled = NULL; if (fflush(stdout)) return errno; -- cgit