From 81d9b21a38f74b5cae1f2e74ccdf076e7f99d1b6 Mon Sep 17 00:00:00 2001 From: Bryce Kwon Date: Sat, 31 Oct 2026 13:19:49 -0700 Subject: Drop rev settings that change nothing repo_init_revisions already sets abbrev, commit_format and show_root_diff to these values, and verbose_header is only read by log_tree_commit, which the log and stats walks never call. --- source/ui-log.c | 4 ---- source/ui-patch.c | 1 - source/ui-stats.c | 4 ---- 3 files changed, 9 deletions(-) (limited to 'source') diff --git a/source/ui-log.c b/source/ui-log.c index b7804c8..2af6967 100644 --- a/source/ui-log.c +++ b/source/ui-log.c @@ -521,10 +521,6 @@ void cgit_print_log(const char *tip, int ofs, int cnt, const char *grep, const c repo_init_revisions(the_repository, &rev, NULL); // The author and committer searches then match the mapped idents. rev.mailmap = cgit_mailmap(); - rev.abbrev = DEFAULT_ABBREV; - rev.commit_format = CMIT_FMT_DEFAULT; - rev.verbose_header = 1; - rev.show_root_diff = 0; rev.ignore_missing = 1; rev.simplify_history = 1; setup_revisions(rev_argv.nr, rev_argv.v, &rev, NULL); diff --git a/source/ui-patch.c b/source/ui-patch.c index 04083fe..5f1e5c6 100644 --- a/source/ui-patch.c +++ b/source/ui-patch.c @@ -103,7 +103,6 @@ void cgit_print_patch(const char *new_rev, const char *old_rev, const char *pref if (ctx.cfg.max_blob_size) repo_settings_set_big_file_threshold(the_repository, (unsigned long)ctx.cfg.max_blob_size * 1024); repo_init_revisions(the_repository, &rev, NULL); - rev.abbrev = DEFAULT_ABBREV; rev.verbose_header = 1; rev.diff = 1; rev.show_root_diff = 1; diff --git a/source/ui-stats.c b/source/ui-stats.c index 555b795..4ed956c 100644 --- a/source/ui-stats.c +++ b/source/ui-stats.c @@ -233,11 +233,7 @@ static int collect_stats(const struct cgit_period *period, struct string_list *a argc += 2; } repo_init_revisions(the_repository, &rev, NULL); - rev.abbrev = DEFAULT_ABBREV; - rev.commit_format = CMIT_FMT_DEFAULT; rev.max_parents = 1; - rev.verbose_header = 1; - rev.show_root_diff = 0; setup_revisions(argc, argv, &rev, NULL); // Prune the walk to the displayed window instead of traversing the // whole history and discarding older commits. The check below still -- cgit