From c16fdac4cedd308911885604a7b3a785388674d9 Mon Sep 17 00:00:00 2001 From: Bryce Kwon Date: Mon, 21 Sep 2026 05:39:34 -1000 Subject: Name the tagged object under its full id --- source/ui-tag.c | 53 +++++++++++++++++++++++++++-------------------------- 1 file changed, 27 insertions(+), 26 deletions(-) (limited to 'source/ui-tag.c') diff --git a/source/ui-tag.c b/source/ui-tag.c index 02fbfc7..56862bb 100644 --- a/source/ui-tag.c +++ b/source/ui-tag.c @@ -17,34 +17,27 @@ #include "ui-shared.h" #include "ui-tag.h" -// The rows share the commit page's three column layout, so a single value -// spans the name and date columns of the tagger row. -static void print_tag_row(const char *revname, const struct object_id *oid) +static void print_name_row(const char *revname, const struct object_id *oid) { - html("tag"); + html("tag name"); html_txt(revname); if (oid) htmlf(" (%s)", oid_to_hex(oid)); html("\n"); } -static void print_object_row(struct object *obj) -{ - html("object"); - cgit_object_link(obj); - html("\n"); -} - -static void print_download_row(const char *revname) +static void print_date_row(struct taginfo *info) { - html("download"); - cgit_print_snapshot_links(ctx.repo, revname, "
"); - html("\n"); + html("tag date\n"); } static void print_tagger_row(struct taginfo *info) { - html("tagger"); + html("tagged by"); // A tag can carry a tagger with no address, and a filter must not be // handed a NULL argument. cgit_open_filter(ctx.repo->email_filter, info->tagger_email ? info->tagger_email : "", "tag"); @@ -54,14 +47,20 @@ static void print_tagger_row(struct taginfo *info) html_txt(info->tagger_email); } cgit_close_filter(ctx.repo->email_filter); - html(""); - if (info->tagger_date > 0) { - html(""); - } + html("\n"); +} + +static void print_object_row(struct object *obj) +{ + html("tagged object"); + cgit_object_link(obj, 1); + html("\n"); +} + +static void print_download_row(const char *revname) +{ + html("download"); + cgit_print_snapshot_links(ctx.repo, revname, "
"); html("\n"); } @@ -106,9 +105,11 @@ static void print_annotated_tag(const char *revname, const struct object_id *oid cgit_print_layout_start(); html("\n"); + print_name_row(revname, oid); + if (info->tagger_date > 0) + print_date_row(info); if (info->tagger) print_tagger_row(info); - print_tag_row(revname, oid); print_object_row(tag->tagged); if (ctx.repo->snapshots) print_download_row(revname); @@ -122,7 +123,7 @@ static void print_lightweight_tag(const char *revname, struct object *obj) { cgit_print_layout_start(); html("
\n"); - print_tag_row(revname, NULL); + print_name_row(revname, NULL); print_object_row(obj); if (ctx.repo->snapshots) print_download_row(revname); -- cgit v2.8.0