From 86b53cba57182539e64dc52072442443988f72c2 Mon Sep 17 00:00:00 2001 From: Bryce Kwon Date: Fri, 16 Oct 2026 22:20:55 -1000 Subject: Sort an empty list without handing qsort a null Every list sorted here is null until its first entry, and C leaves a null base undefined even with nothing to sort. glibc declares it nonnull, and a UBSan build aborted the stats page of a repository with no commits in the window. --- source/ui-stats.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'source/ui-stats.c') diff --git a/source/ui-stats.c b/source/ui-stats.c index f200b63..a332335 100644 --- a/source/ui-stats.c +++ b/source/ui-stats.c @@ -450,7 +450,7 @@ void cgit_show_stats(void) } if (collect_stats(period, &authors)) return; - qsort(authors.items, authors.nr, sizeof(struct string_list_item), cmp_total_commits); + cgit_qsort(authors.items, authors.nr, sizeof(struct string_list_item), cmp_total_commits); top = ctx.qry.ofs; if (!top) -- cgit 2.12.1