From 44c1d728b11fb970d040313d519a6372ac77652c Mon Sep 17 00:00:00 2001 From: Bryce Kwon Date: Sat, 7 Nov 2026 08:34:51 -1000 Subject: Keep cgit under Valgrind whichever way it is asked The library runs a script again for --tee, --verbose-log and --stress with the arguments setup.sh left it, and --valgrind was no longer among them, so -V --valgrind ran cgit bare. --valgrind= reached the library instead, which then wrapped every Git command and left cgit alone. --valgrind-only is refused, as it would need the library's own per-test switching. --- README.txt | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'README.txt') diff --git a/README.txt b/README.txt index a2d8185..83c376a 100644 --- a/README.txt +++ b/README.txt @@ -334,8 +334,10 @@ The scripts take the options of Git's test library, such as -v to show what each test does and prints, -i to stop at the first failure and --run to pick tests by number, and make test passes them on through CGIT_TEST_OPTS. A failing test shows only its name and its commands, so run its script again with -v to -see why it failed. The trash directories need a local filesystem, as the cache -tests rely on flock locks, which NFS can only emulate. +see why it failed. --valgrind runs cgit, and only cgit, under Valgrind's +memcheck, and --valgrind= under another tool. The trash directories need +a local filesystem, as the cache tests rely on flock locks, which NFS can only +emulate. make test builds with the flags on its own command line, so after tools/build-development.sh a plain make test would rebuild and test an ordinary -- cgit 2.12.1