Age	Commit message (Collapse)	Author	Lines
15 hours	Run the file size limit tests without Valgrind	Bryce Kwon	-2/+6
	Under --valgrind both tests failed with an exit status of 1 and no page, because Valgrind gave up as it started when the write of its gdbserver file was refused, so cgit never ran.
16 hours	Percent-encode a submodule path in its link	Bryce Kwon	-0/+18
	A module-link template takes the path as the tree names it, so a path holding a space or a byte past ASCII gave an href that broke there. The url is now encoded the way a clone url is.
16 hours	Add filename* for a download name past ASCII	Bryce Kwon	-3/+38
	The plain, snapshot and blob pages sent a name such as café.txt raw in filename, which a client may read as ISO-8859-1. RFC 6266 has such a name sent again as filename*, percent-encoded in UTF-8, for a client that knows the form, with filename first for one that does not. The extended form carries UTF-8 alone, so a name that is not valid UTF-8 keeps the plain filename by itself.
16 hours	Percent-encode a clone url in its href	Bryce Kwon	-1/+35
	An href carried git://example.org/dépôt.git as it was, and the space of "with space" too, neither of which a url may hold. html_url_path would also encode the plus of git+ssh, which breaks the scheme, and the percent of an escape the url was written with, so a whole url gets a helper that encodes only the bytes RFC 3986 allows nowhere.
16 hours	Keep a space in a repository url in one clone url	Bryce Kwon	-0/+16
	The shared repository "with space" listed git://example.org/with and space.git as two clone urls, and the head linked the first alone. The manual calls clone-url a list of templates, so the list is now split before each template is expanded. A clone-prefix was right already, as the url is joined to it after the split.
16 hours	Show a full index page for a negative offset	Bryce Kwon	-0/+18
	The query parser takes an offset as low as -1, which the stats page reads as every author, so the index clamps it for itself, as the log and refs pages already do.
16 hours	Move the root-readme test to the index tests	Bryce Kwon	-12/+12
	The test reads the index and the site about page, both drawn by ui-repolist.c. Its site had no repositories, so the index it read was the error page, and a readme printed below the list went unseen. The shared repositories give it a real index.
16 hours	Test a repository url in UTF-8	Bryce Kwon	-0/+21
16 hours	Test a file name in UTF-8	Bryce Kwon	-0/+39
16 hours	Test the about path check for each kind of readme	Bryce Kwon	-38/+40
	Three tests exercised the single path check in about_fn, each through one kind of readme, and none through a readme read from the head being browsed.
16 hours	Test that a background rescan lets the request go	Bryce Kwon	-0/+75
	The child that rebuilds an expired list drops the request's stdin, stdout and stderr, and nothing showed it, so a child that kept them would hold the visitor's connection open for the whole scan.
16 hours	Give the cgit hold-lock runs a time limit	Bryce Kwon	-3/+12
	hold-lock has to start cgit inside its hold, so it could not use cgit_rc, and a cgit that blocked on the held lock stalled the run for good instead of failing. The strace helper cannot use cgit_rc either, and now says so.
16 hours	Check a filter never gets the client's stdout	Bryce Kwon	-12/+17
	The copy of the client's stdout kept during a fill is marked close-on-exec, but nothing checked it, so a filter left holding the connection after the request ended passed.
16 hours	Let the fd filter find the lock file itself	Bryce Kwon	-4/+9
	The test named the lock file through a variable set for cgit alone, which kept it from going through cgit_rc, as a variable set ahead of a shell function call does not portably reach the commands it runs. The slot names fixed at 00000000 were never explained either.
16 hours	Test a cache-max-slot-size of 0 and below	Bryce Kwon	-0/+19
	No test set either value, so a size check that took 0 as a limit of no bytes, or a parser that ignored such a value, passed. Under the 64 MB default an ignored value still keeps the big page, so each one follows a limit the page is past.
16 hours	Test that each page ttl of 0 leaves its page out	Bryce Kwon	-0/+31
	cache-about-ttl and cache-snapshot-ttl were never set, cache-index-ttl only by the way and cache-summary-ttl only elsewhere at 0, so a page that took the wrong ttl, or a setting that was never read, passed.
16 hours	Check the broken commit page from start to end	Bryce Kwon	-2/+11
	The test looked only for the error and a single status line, so a page that stopped at the error passed. The empty cache-root proved nothing either without a page that brokenrc does cache.
16 hours	Test the cache key length a slot can take	Bryce Kwon	-11/+15
	The over-long key was 6000 bytes and the ordinary one about 30, so the limit could move by kilobytes either way and pass, and the warning went to /dev/null.
16 hours	Write bigkeyrc and slotsizerc in the setup test	Bryce Kwon	-7/+7
	About ten tests use bigkeyrc and one more uses slotsizerc, and each was written inside an earlier test, so a --run that left that test out failed the ones after it.
16 hours	Give the repository open test a config of its own	Bryce Kwon	-2/+5
	It read the config the 404 test had written, so it could not run alone with --run.
16 hours	Show the missing repository's config does cache	Bryce Kwon	-2/+9
	An empty cache passed just as well when nothing was cached at all.
16 hours	Show the second scan reads the cached list	Bryce Kwon	-1/+4
	A first request that left no list behind made the second scan again, and the test passed just the same.
16 hours	Test a number left empty in cgitrc	Bryce Kwon	-0/+9
16 hours	Test a word in a scanned repository's cgitrc	Bryce Kwon	-0/+14
17 hours	Point the filter script at its SIGPIPE test	Bryce Kwon	-0/+1
	The test there fails once the child keeps cgit's ignored SIGPIPE, so a second one here would add nothing.
17 hours	Describe the whole filter script in its header	Bryce Kwon	-5/+9
17 hours	Test the ways a Lua filter can fail	Bryce Kwon	-3/+71
	A script that failed to load and was carried on with would still fail at filter_open, so the two load tests also check the reason Lua gave.
17 hours	Test filter commands without a known prefix	Bryce Kwon	-0/+16
17 hours	Test an exec filter killed by a signal	Bryce Kwon	-0/+15
17 hours	Check where a Lua filter's loading output lands	Bryce Kwon	-4/+4
	The test found the text anywhere on the page, so output that slipped behind the closing tag, as print once did, still passed.
17 hours	Give each filter test a config of its own	Bryce Kwon	-18/+10
	Five tests read or rewrote a config an earlier test had written, so none of them could run alone with --run.
17 hours	Render each filter check in its own test	Bryce Kwon	-19/+12
	A check read the tmp an earlier test had left, so run alone or after a failed fetch it read a stale page. Each test now asks for its own page through cgit_ok_url, which renders it past the shared cache and fails on a logged error or a page cut short.
17 hours	Name what the stylesheet and script tests check	Bryce Kwon	-5/+5
	Their titles promised behaviour only a browser shows, while each reads the stylesheet, the script or the tag that loads it.
17 hours	Check every selector of the monospace rule	Bryce Kwon	-4/+8
	The test found the rule by its first selector and knew pre only by the comma after it, so reordering the list failed it while losing kbd or samp did not.
17 hours	Test the settings that fill the head and header	Bryce Kwon	-0/+23
17 hours	Test the index title and a repository's own name	Bryce Kwon	-1/+26
17 hours	Test the settings that change the logo	Bryce Kwon	-5/+33
17 hours	Set the site title once in the markup tests	Bryce Kwon	-6/+8
17 hours	Check settings below scan-path miss the scan	Bryce Kwon	-3/+37
17 hours	Check the manual's contents against its sections	Bryce Kwon	-1/+12
17 hours	Read any module-link path in the sample as one key	Bryce Kwon	-4/+3
	The sample's example passed only because its path holds a slash, which the pattern for plain keys leaves out. A path without one was read as a key of its own and reported as undocumented, and a mimetype extension holding a character outside the pattern would have been dropped.
17 hours	Describe every check in the docs test header	Bryce Kwon	-5/+5
17 hours	Test the clamp on the page offset	Bryce Kwon	-0/+10
17 hours	Test the clamp on the diff context	Bryce Kwon	-0/+20
17 hours	Tell the whole commit notice from the per file one	Bryce Kwon	-4/+4
	Both open with the same sentence, so a grep for it passed on either.
17 hours	Check where the oversized file diff links to	Bryce Kwon	-4/+4
	The small file test also read the page the test before it left, so it renders the commit itself now.
17 hours	Count every ref a count of 0 lists	Bryce Kwon	-2/+11
	One branch and one tag stood for the whole listing, so a count of 0 that dropped the rest still passed, and -1 is only compared with it.
17 hours	Match the overflow links on the refs page	Bryce Kwon	-2/+3
	The test read the page the test before it left and looked for the bare path, which other links on the page also hold.
17 hours	Share the security tests' repeated setup	Bryce Kwon	-36/+35
17 hours	Share the robustness tests' repeated setup	Bryce Kwon	-182/+88
	The status check now also fails on a second status line, which a page that dies after its headers puts out, so every request is held to one answer rather than the few that counted.