AgeCommit message (Collapse)AuthorLines
Give the repository open test a config of its ownBryce Kwon-2/+5
It read the config the 404 test had written, so it could not run alone with --run.
Show the missing repository's config does cacheBryce Kwon-2/+9
An empty cache passed just as well when nothing was cached at all.
Show the second scan reads the cached listBryce Kwon-1/+4
A first request that left no list behind made the second scan again, and the test passed just the same.
Test a number left empty in cgitrcBryce Kwon-0/+9
Test a word in a scanned repository's cgitrcBryce Kwon-0/+14
Report a max-stats value that names no periodBryce Kwon-0/+27
A value cgit does not know as a period turns the statistics page off, so a typo such as "decade" read the same as leaving stats off on purpose. The empty value stays quiet because a cached repolist writes it for a repository that turned stats off.
Check a warning raised inside an included fileBryce Kwon-0/+1
The include run checked only the line in the outer file, so a warning from the included one could have named the outer file and passed.
Match logged paths as fixed stringsBryce Kwon-12/+12
The messages hold the trash directory's path and were matched as patterns, so a checkout path holding a bracket or a star would break them.
Test DOS line endings and stray lines in cgitrcBryce Kwon-0/+15
Without the fold of a carriage return before a newline, repo.path keeps a trailing one and the repository cannot be opened, and no test had a file saved that way. Semicolon comments and a line with no equals sign were untested too.
Test the include nesting limitBryce Kwon-0/+28
Nothing reached the guard that stops a file including itself, so its loss would have gone unseen until a site's own cgitrc recursed until the stack gave out.
Report a snapshot format name that matches nothingBryce Kwon-0/+19
Log the path of a repository that will not openBryce Kwon-0/+14
The 404 page names only the repository and nothing reached the log, so a mistyped repo.path left no trace of the path cgit had tried.
Report a word where cgitrc expects a numberBryce Kwon-0/+36
atoi reads "yes" or "true" as 0, so repo.hide=yes, or cgit.hide true in a scanned repository's git config, silently did nothing. The values keep that meaning, since honouring them now would hide repositories on upgrade, but each one is logged with its file and line.
Report a cgitrc or include that cannot be readBryce Kwon-0/+37
A missing or unreadable cgitrc left only "No repositories found" and an empty log, the commonest first mistake with no trace of its cause. A scanned repository's own cgitrc stays quiet, since most have none.
Drain the about filter in the config testsBryce Kwon-2/+6
Move the later tests to the config writersBryce Kwon-15/+8
The one-line request wrappers go with them. Configs with several repositories, a key out of place on purpose, the cache on or no repository of their own stay written out.
Cut test comments that repeat what is said nearbyBryce Kwon-6/+1
Make the main cgitrc filter check run the filterBryce Kwon-3/+6
The check asked for the summary page, which never runs an about filter, so it passed with exec:/bin/true where no such file exists, and with a filter that does not exist at all. Its first line read the stderr the previous test left behind. execvp searches the PATH, so a plain true runs the same everywhere.
Run a config comment to the end of its lineBryce Kwon-0/+16
skip_line stopped at a NUL as well as at a newline, so the rest of the comment after one was read as a setting.
Harden the request path, scan and error recoveryBryce Kwon-3/+3
Answer 404 for a repository whose path is missingBryce Kwon-2/+21
Gate scanned filters with trust-scan-filtersBryce Kwon-4/+30
Report ignored config keys on stderrBryce Kwon-0/+53