Age	Commit message (Collapse)	Author	Lines
45 hours	Check that a signature covers every cookie field	Bryce Kwon	-0/+20
	The only tampering tried was a flipped signature, a field swapped for another and the binding, so a payload that left out the expiry, the salt or the value still passed, and a captured session could have been extended for ever.
45 hours	Check that the secret keys every signature	Bryce Kwon	-0/+12
	Every check signed and verified under one pinned secret, so a sign() that left the secret out of the HMAC key, which makes every cookie forgeable, passed.
45 hours	Check that the auth secret is made safely	Bryce Kwon	-11/+112
	The checks replaced get_secret with a constant, so its success path never ran, and the luaposix stand-in had no link or unlink and a umask that ignored its argument. Dropping the tightened mask, which leaves the secret readable by everyone under the usual 022, or accepting a short secret, passed. The real get_secret now makes the secret in the run's directory through stand-ins that behave like the calls they replace, and the checks cover the mask and its restoration, the link race, the temporary file, reuse and a secret written by hand.
45 hours	Give each auth unit run a directory of its own	Bryce Kwon	-16/+18
	test-auth.lua wrote its fixtures into whatever directory it was started from, so a run by hand from the checkout left auth-users and its siblings behind, and the checks assumed no auth-users-missing or no-such-directory already sat there. It now refuses to run without a directory, and t0505 hands each interpreter and variant a fresh one. The interpreter and paths are expanded inside the test body rather than pasted into it in single quotes, so a path holding a quote no longer breaks the eval.
48 hours	Check that the outermost avatar brackets come off	Bryce Kwon	-0/+4
	With one pair of brackets, matching the innermost pair would have passed the old check as well.
48 hours	Say why the Lua search paths reach the tests	Bryce Kwon	-1/+4
48 hours	Give the harness cgit's print and its other sinks	Bryce Kwon	-2/+35
	Lua's own print wrote outside the collected output, so a stray print in a filter passed every check while under cgit it lands on the page. html_url_arg and html_include were missing, which only a filter using them would have found.
48 hours	Compare link-trailers output whole	Bryce Kwon	-1/+5
	A short object name was checked only for a missing anchor, and the value that passes through untouched never held the entities cgit escapes it with, so escaping it again would have passed.
48 hours	Compare link-commits output whole	Bryce Kwon	-8/+13
	Four checks only looked for a missing anchor, which output with the text dropped also passes, and no message held the entities cgit escapes it with.
48 hours	Time the other filters at two lengths as well	Bryce Kwon	-26/+59
	The avatar checks held a 40000 byte address to half a second, twenty times tighter than the readme budget that already failed on a slow host, and in stub mode nearly all of that time went on the fake digest. Link-commits and link-trailers had no check on a long input at all. The readme checks' method moves into the harness so all four share it. A single timing of each length let a busy host that took the CPU away during the longer one make a linear pass look quadratic. The lengths now take turns and the fastest timing of each counts, since a busy host can slow one timing but rarely all five. A ratio under six ends the turns at once, so only one near the bound of ten waits for all five.
2 days	Hold the avatar stub checks to an absolute hash	Bryce Kwon	-7/+28
	The stub mode checks only compared hashes with each other, and the stand-in digest took any algorithm name, so md5, a misspelt sha256 or hex in capitals passed everywhere luaossl is missing, which is every machine here. The comparisons also passed with no hash found on either side.
2 days	Cover how link-trailers applies its rules	Bryce Kwon	-0/+26
	Skipping a malformed rule, a rule without a key, the switch for bare urls and the shipped CVE example were untested, and the only url kept from linking was one holding a quote, so a broader scheme check would have let javascript:// through.
2 days	Cover how link-commits applies its rules	Bryce Kwon	-0/+41
	Skipping a malformed rule, the tie between two rules, the scan past an empty match, a rule with no capture and the switch for object names were all untested, and none of the shipped examples beyond the issue rule had ever been loaded.
2 days	Cover the rest of syntax-highlight's output	Bryce Kwon	-4/+22
	No token ever took hl-type or hl-comment, so a typo in either row, or a rule gone from the stylesheet, passed. Nothing fed the filter a NUL byte or a blob of exactly the size cap either.
2 days	Check the lexer modules the filter cannot use	Bryce Kwon	-3/+54
	A module called lexer that is not Scintillua, a Scintillua older than 6.0 without detect(), lexers that cannot load lpeg and a lexer that returns no token list were all documented and none was tried.
2 days	Drop the section labels from the readme checks	Bryce Kwon	-4/+0
2 days	Cover the rest of the man macros	Bryce Kwon	-0/+25
2 days	Cover the rest of the markdown grammar	Bryce Kwon	-0/+53
	The changelog for 2.12.0 says a list split by a code block keeps counting, and only the split by a blank line was checked.
2 days	Pair each readme absence check with what renders	Bryce Kwon	-2/+6
	Four checks only looked for something missing, which a dropped or plain text rendering also satisfies, and the spacing macro check missed a 0 drawn at the start of a line.
2 days	Never give two headings the same anchor	Bryce Kwon	-0/+10
	A repeat's count was keyed on the bare text, so a heading whose text already ended in that count took the same anchor, as "Twice 1" did after two of "Twice", and "About 1" after "About". A link to either then landed on the first. The count now goes on up past any anchor already handed out, the way GitHub's slugger does.
2 days	Check what the nesting rules actually render	Bryce Kwon	-3/+6
	The emphasis bomb checked only that the output was not empty, which it never is, and its input never nests. No input reaches the ceiling on inline nesting either, since an emphasis cannot hold its own kind, so the check now proves the nesting that does happen. Past the quote ceiling only the innermost text was looked for, and any x passed.
2 days	Check the two fallbacks around rendering a readme	Bryce Kwon	-0/+13
2 days	Check the log line for lexers that are not found	Bryce Kwon	-5/+43
	Every check set CGIT_SCINTILLUA_PATH, which the filter takes as given, so the line for a server with no Scintillua at all never ran and deleting it passed. The harness can now clear a variable and hide the directories the filter probes. A lexer.lua anywhere on LUA_PATH also loaded in place of the missing one, so the fallback runs now keep every Lua module out of reach.
2 days	Prove the avatar fallback on any machine	Bryce Kwon	-1/+2
	The page without icons was checked only where cgit's Lua lacked luaossl, so a machine that has it never ran the fallback. It now runs with every Lua search path pointed at an empty directory, and the log line is compared whole. Writing the config needs no Lua, so that step runs everywhere too.
2 days	Prove the about page fallback on any machine	Bryce Kwon	-1/+24
	The fallback through cgit ran only where cgit's own Lua lacked lpeg, and every machine the suite runs on has it, so the test never ran. With every Lua search path pointed at an empty directory it runs anywhere. It now also checks that the readme's markup is escaped, as its title said, and compares the whole log line.
2 days	Fail a unit check run that made no check	Bryce Kwon	-0/+5
2 days	Decide every unit check skip in the shell	Bryce Kwon	-25/+52
	Where a standalone Lua had no lpeg, the harness skipped the markdown and man checks itself, behind a note the test library hides, and the test passed on the six checks left. The real luaossl checks were left out the same way. Each now shows as a skip under a prerequisite named for the interpreter, and a misspelt mode fails rather than running the default.
2 days	Show unit checks as skipped when no Lua is found	Bryce Kwon	-2/+5
	With no standalone interpreter on the path the unit checks were never registered, so they counted as neither run nor skipped, and a fault in the version probe dropped them all behind one line of output. The test bodies now expand their paths as they run, so a quote in a path no longer breaks them.
2 days	Run each standalone Lua version once	Bryce Kwon	-5/+27
	A plain lua is usually one of the versioned names again, as lua and lua5.5 are here, so every 5.5 check ran twice, while names such as lua54 and lua-5.4 were never looked for. A test now names the version that ran, since "under lua" did not say which one it was.
2 days	Stop the run when the Lua probe fails	Bryce Kwon	-2/+14
	The probe piped cgit into grep, so a crash or a sanitizer abort while probing read as a missing module, and t0501, t0504 and t0505 then expected the fallback on a machine that has the module.
2 days	Check that link-trailers encodes a rule capture	Bryce Kwon	-0/+7
	As in link-commits, every capture was hex or digits. A string replacement there would also raise outside the pcall that guards the pattern and take the whole page down.
2 days	Check that link-commits encodes a rule capture	Bryce Kwon	-0/+7
	Every capture the checks used was hex or digits, which encoding leaves alone, so the filter passed with url_encode gone and a broader rule could then have broken out of the href.
2 days	Check that markup inside a token is escaped	Bryce Kwon	-0/+3
	Every escape the checks looked at sat between tokens or in the tail a lexer left untagged, so a filter that escaped only those would have passed with a string literal reaching the page raw.
2 days	Time each hostile readme at two lengths	Bryce Kwon	-17/+48
	One ten second budget covered several inputs, so a failure did not say which had regressed, and it allowed ten times the second a readme is held to while leaving a slow host little room. A linear render costs four times as much at four times the length and a quadratic one sixteen, whatever the host. The cap on unclosed brackets had no check at all, and the line of \h' escapes timed nothing that is bounded.
2 days	Check that a link's fragment is escaped	Bryce Kwon	-0/+3
2 days	Prove a control byte cannot hide a link's scheme	Bryce Kwon	-2/+9
	The old check split the scheme with a newline, which ends the line before a link can form, so it passed with the strip removed.
3 days	Fetch avatar icons without a Referer	Bryce Kwon	-0/+1
	The icons came from Gravatar or Libravatar with the page's url as the Referer, so the service learned which repositories and commits each visitor looked at.
4 days	Read the login form table as layout	Bryce Kwon	-0/+1
7 days	Name a missing Lua module in the error log	Bryce Kwon	-0/+17
7 days	Log failed logins	Bryce Kwon	-0/+7
	The login posts outside any repository, so the log line names the repository by the page its signed way back leads to.
7 days	Say that logging in needs https	Bryce Kwon	-1/+12
	Only HTTPS=on counts, the same test cgit makes before it writes an https link of its own.
7 days	Tell a signed-in visitor they have no access	Bryce Kwon	-0/+7
7 days	Say when logins are unavailable	Bryce Kwon	-1/+37
	The way back was signed part way through the form, so while the secret's directory did not exist, or a library was missing, cgit's error landed inside the hidden input and the page broke off there with no fields.
7 days	Keep counting across a split ordered list	Bryce Kwon	-0/+7
9 days	Find a capitalised extension's lexer again	Bryce Kwon	-5/+12
	Scintillua's detect() matches an extension by its case, and the fallback e227d1f dropped had lowercased it, so MAIN.C and SETUP.PY lost their colour. The fake lexer now answers only for the suffixes it knows, as Scintillua does, which is what lets the check see it.
10 days	Write a session's expiry in whole seconds	Bryce Kwon	-0/+11
	On Lua 5.3 and later a length worked out with a fraction, such as 1.5 * 24 * 60 * 60, is a float, so the signed expiry came out as 1793609024.0, which validate_value refuses, and every login failed. Max-Age took the same .0, which makes a browser ignore it.
10 days	Set the Lua prerequisite once for every test	Bryce Kwon	-25/+16
	setup.sh already asks the binary, so the seven scripts that each turned the answer into a prerequisite now share one. test-lib names the missing prerequisite beside every test it skips, so the notes that cgit lacks Lua go, while the ones announcing a fallback stay. Every script that listed the standalone interpreters asked for the same ceiling, so lib.sh now builds that list for all of them.
10 days	Share the request helpers in the auth checks	Bryce Kwon	-77/+49
	The two identical posts for an unknown user become one, and no two checks share a name, so a failure report points at a single check.
10 days	Let an unmirrored sink fail the way Lua would	Bryce Kwon	-12/+0
10 days	Drop the auth stubs no check reaches	Bryce Kwon	-20/+6
	Every check replaces get_secret, the only caller of posix.sys.stat, link and unlink, and nothing outside the harness calls preload.