AgeCommit message (Collapse)AuthorLines
Time the other filters at two lengths as wellBryce Kwon-26/+59
The avatar checks held a 40000 byte address to half a second, twenty times tighter than the readme budget that already failed on a slow host, and in stub mode nearly all of that time went on the fake digest. Link-commits and link-trailers had no check on a long input at all. The readme checks' method moves into the harness so all four share it. A single timing of each length let a busy host that took the CPU away during the longer one make a linear pass look quadratic. The lengths now take turns and the fastest timing of each counts, since a busy host can slow one timing but rarely all five. A ratio under six ends the turns at once, so only one near the bound of ten waits for all five.
Hold the avatar stub checks to an absolute hashBryce Kwon-7/+28
The stub mode checks only compared hashes with each other, and the stand-in digest took any algorithm name, so md5, a misspelt sha256 or hex in capitals passed everywhere luaossl is missing, which is every machine here. The comparisons also passed with no hash found on either side.
Cover how link-trailers applies its rulesBryce Kwon-0/+26
Skipping a malformed rule, a rule without a key, the switch for bare urls and the shipped CVE example were untested, and the only url kept from linking was one holding a quote, so a broader scheme check would have let javascript:// through.
Cover how link-commits applies its rulesBryce Kwon-0/+41
Skipping a malformed rule, the tie between two rules, the scan past an empty match, a rule with no capture and the switch for object names were all untested, and none of the shipped examples beyond the issue rule had ever been loaded.
Cover the rest of syntax-highlight's outputBryce Kwon-4/+22
No token ever took hl-type or hl-comment, so a typo in either row, or a rule gone from the stylesheet, passed. Nothing fed the filter a NUL byte or a blob of exactly the size cap either.
Check the lexer modules the filter cannot useBryce Kwon-3/+54
A module called lexer that is not Scintillua, a Scintillua older than 6.0 without detect(), lexers that cannot load lpeg and a lexer that returns no token list were all documented and none was tried.
Drop the section labels from the readme checksBryce Kwon-4/+0
Cover the rest of the man macrosBryce Kwon-0/+25
Cover the rest of the markdown grammarBryce Kwon-0/+53
The changelog for 2.12.0 says a list split by a code block keeps counting, and only the split by a blank line was checked.
Pair each readme absence check with what rendersBryce Kwon-2/+6
Four checks only looked for something missing, which a dropped or plain text rendering also satisfies, and the spacing macro check missed a 0 drawn at the start of a line.
Never give two headings the same anchorBryce Kwon-0/+10
A repeat's count was keyed on the bare text, so a heading whose text already ended in that count took the same anchor, as "Twice 1" did after two of "Twice", and "About 1" after "About". A link to either then landed on the first. The count now goes on up past any anchor already handed out, the way GitHub's slugger does.
Check what the nesting rules actually renderBryce Kwon-3/+6
The emphasis bomb checked only that the output was not empty, which it never is, and its input never nests. No input reaches the ceiling on inline nesting either, since an emphasis cannot hold its own kind, so the check now proves the nesting that does happen. Past the quote ceiling only the innermost text was looked for, and any x passed.
Check the two fallbacks around rendering a readmeBryce Kwon-0/+13
Check the log line for lexers that are not foundBryce Kwon-5/+43
Every check set CGIT_SCINTILLUA_PATH, which the filter takes as given, so the line for a server with no Scintillua at all never ran and deleting it passed. The harness can now clear a variable and hide the directories the filter probes. A lexer.lua anywhere on LUA_PATH also loaded in place of the missing one, so the fallback runs now keep every Lua module out of reach.
Prove the avatar fallback on any machineBryce Kwon-1/+2
The page without icons was checked only where cgit's Lua lacked luaossl, so a machine that has it never ran the fallback. It now runs with every Lua search path pointed at an empty directory, and the log line is compared whole. Writing the config needs no Lua, so that step runs everywhere too.
Prove the about page fallback on any machineBryce Kwon-1/+24
The fallback through cgit ran only where cgit's own Lua lacked lpeg, and every machine the suite runs on has it, so the test never ran. With every Lua search path pointed at an empty directory it runs anywhere. It now also checks that the readme's markup is escaped, as its title said, and compares the whole log line.
Fail a unit check run that made no checkBryce Kwon-0/+5
Decide every unit check skip in the shellBryce Kwon-25/+52
Where a standalone Lua had no lpeg, the harness skipped the markdown and man checks itself, behind a note the test library hides, and the test passed on the six checks left. The real luaossl checks were left out the same way. Each now shows as a skip under a prerequisite named for the interpreter, and a misspelt mode fails rather than running the default.
Show unit checks as skipped when no Lua is foundBryce Kwon-2/+5
With no standalone interpreter on the path the unit checks were never registered, so they counted as neither run nor skipped, and a fault in the version probe dropped them all behind one line of output. The test bodies now expand their paths as they run, so a quote in a path no longer breaks them.
Run each standalone Lua version onceBryce Kwon-5/+27
A plain lua is usually one of the versioned names again, as lua and lua5.5 are here, so every 5.5 check ran twice, while names such as lua54 and lua-5.4 were never looked for. A test now names the version that ran, since "under lua" did not say which one it was.
Stop the run when the Lua probe failsBryce Kwon-2/+14
The probe piped cgit into grep, so a crash or a sanitizer abort while probing read as a missing module, and t0501, t0504 and t0505 then expected the fallback on a machine that has the module.
Check that link-trailers encodes a rule captureBryce Kwon-0/+7
As in link-commits, every capture was hex or digits. A string replacement there would also raise outside the pcall that guards the pattern and take the whole page down.
Check that link-commits encodes a rule captureBryce Kwon-0/+7
Every capture the checks used was hex or digits, which encoding leaves alone, so the filter passed with url_encode gone and a broader rule could then have broken out of the href.
Check that markup inside a token is escapedBryce Kwon-0/+3
Every escape the checks looked at sat between tokens or in the tail a lexer left untagged, so a filter that escaped only those would have passed with a string literal reaching the page raw.
Time each hostile readme at two lengthsBryce Kwon-17/+48
One ten second budget covered several inputs, so a failure did not say which had regressed, and it allowed ten times the second a readme is held to while leaving a slow host little room. A linear render costs four times as much at four times the length and a quadratic one sixteen, whatever the host. The cap on unclosed brackets had no check at all, and the line of \h' escapes timed nothing that is bounded.
Check that a link's fragment is escapedBryce Kwon-0/+3
Prove a control byte cannot hide a link's schemeBryce Kwon-2/+9
The old check split the scheme with a newline, which ends the line before a link can form, so it passed with the strip removed.
Fetch avatar icons without a RefererBryce Kwon-0/+1
The icons came from Gravatar or Libravatar with the page's url as the Referer, so the service learned which repositories and commits each visitor looked at.
Read the login form table as layoutBryce Kwon-0/+1
Name a missing Lua module in the error logBryce Kwon-0/+17
Log failed loginsBryce Kwon-0/+7
The login posts outside any repository, so the log line names the repository by the page its signed way back leads to.
Say that logging in needs httpsBryce Kwon-1/+12
Only HTTPS=on counts, the same test cgit makes before it writes an https link of its own.
Tell a signed-in visitor they have no accessBryce Kwon-0/+7
Say when logins are unavailableBryce Kwon-1/+37
The way back was signed part way through the form, so while the secret's directory did not exist, or a library was missing, cgit's error landed inside the hidden input and the page broke off there with no fields.
Keep counting across a split ordered listBryce Kwon-0/+7
Find a capitalised extension's lexer againBryce Kwon-5/+12
Scintillua's detect() matches an extension by its case, and the fallback e227d1f dropped had lowercased it, so MAIN.C and SETUP.PY lost their colour. The fake lexer now answers only for the suffixes it knows, as Scintillua does, which is what lets the check see it.
Write a session's expiry in whole secondsBryce Kwon-0/+11
On Lua 5.3 and later a length worked out with a fraction, such as 1.5 * 24 * 60 * 60, is a float, so the signed expiry came out as 1793609024.0, which validate_value refuses, and every login failed. Max-Age took the same .0, which makes a browser ignore it.
Set the Lua prerequisite once for every testBryce Kwon-25/+16
setup.sh already asks the binary, so the seven scripts that each turned the answer into a prerequisite now share one. test-lib names the missing prerequisite beside every test it skips, so the notes that cgit lacks Lua go, while the ones announcing a fallback stay. Every script that listed the standalone interpreters asked for the same ceiling, so lib.sh now builds that list for all of them.
Share the request helpers in the auth checksBryce Kwon-77/+49
The two identical posts for an unknown user become one, and no two checks share a name, so a failure report points at a single check.
Let an unmirrored sink fail the way Lua wouldBryce Kwon-12/+0
Drop the auth stubs no check reachesBryce Kwon-20/+6
Every check replaces get_secret, the only caller of posix.sys.stat, link and unlink, and nothing outside the harness calls preload.
Drop auth guards for input cgit never sendsBryce Kwon-3/+4
cgit passes an empty string, never nil, when a request names no repository, so the check that the index stays up proved nothing, and auth-file in fact refuses the index too while its repos file cannot be read. A session_seconds of 0 signs a session that has expired by the time it comes back, so it needs no branch of its own in set_cookie.
Strip control characters from the location aloneBryce Kwon-2/+0
set_cookie only ever writes an empty value or a token secure_value built from url-encoded text, digits and hex, so stripping it changed nothing.
Take a signed cookie apart with one matchBryce Kwon-0/+1
The loop let a valid cookie through with a field appended, a doubled separator or a zero in front of its expiry. The payload now carries the expiry as written, so only the spelling secure_value issues verifies.
Drop a highlighter check that tested the harnessBryce Kwon-6/+0
The filter hands a NUL through untouched, and only the harness's copy of cgit's sink cut the text there, so the check would have failed the day the filter replaced NULs the way about-render does.
Drop the highlighter's extension fallbackBryce Kwon-14/+5
The table of extensions and the second lookup served only a Scintillua with no detect(), which now leaves every file uncoloured but escaped. The fake detect() names a lexer after the file's suffix, so every test lexer is reached through it.
Drop a stray blank line from about-render's testsBryce Kwon-1/+0
Drop the readme hooks that nothing readsBryce Kwon-5/+4
Nothing in assets/ or in README's list of hooks reads a fenced block's data-lang or the manpage class on a man page's wrapper.
Render the man pages that generators writeBryce Kwon-2/+69
DocBook, pod2man and hand written pages leaked roff onto the page. Font escapes inside no fill blocks, comments, layout escapes such as \% and \c, the colours and half line moves around DocBook's links, and the requests and macro definitions their preambles open with all showed through. Those now draw nothing, the common named characters and strings render, .EX and pod2man's .Vb read as code, a .TP tag takes a line of its own and the alternating font macros switch fonts between their arguments. Anything rarer still falls back to its text.
Render more of the markdown seen in readmesBryce Kwon-0/+26
A line of equals signs or dashes under a paragraph now makes a heading of it, as on GitHub, instead of running into its text, and any other rule ends the paragraph. Four spaces or a tab start a code block, and an escaped pipe stays in its table cell. A link opening with two slashes or backslashes in any mix leads to another site, so it renders as text like the plain scheme relative one already did.