Age	Commit message (Collapse)	Author	Lines
18 hours	Lock a cache slot with flock	Bryce Kwon	-7/+6
	The slot lock was a POSIX record lock, which a process loses the moment any descriptor on the file closes, and the fill puts the lock file on stdout, which every exec filter and snapshot compressor closes with its dup2. A second request on the slot could then rebuild it under the first and splice the two pages. An flock holds until the last descriptor goes.
18 hours	Abandon a fill whose last flush fails to write	Bryce Kwon	-2/+4
	The slot being filled was forgotten before the page's final flush, so a write that failed there, on a full disk for one, could not abandon the fill: cgit died into the lock file instead and the visitor got nothing. The mid-page path already delivered the page from the lock file.
18 hours	Hold patch and rawdiff to max-blob-size	Bryce Kwon	-0/+8
	Both pages hand the diff to git, whose own limit on an inlined blob is 512 MB, so a commit adding a blob the other views refuse was inflated and diffed in full. The cap is passed through to git, which shows such a blob as binary.
18 hours	Keep every control byte out of a header value	Bryce Kwon	-0/+4
	A quoted header value escaped only the quote, the backslash, CR and LF. A web server refuses a response whose header holds any other control byte, so a file named with one could not be downloaded at all.
18 hours	Widen the cache ttl before multiplying it	Bryce Kwon	-1/+3
	A ttl in the tens of millions of minutes overflowed the int it was multiplied in.
18 hours	Hold a scanned defbranch to a ref name	Bryce Kwon	-1/+3
	The index stats the default branch below the repository to date it, and a scanned repository sets its own defbranch, which was not held to what a ref may hold, so one spelled as a path reached a file outside.
18 hours	Answer the plain view once for duplicate entries	Bryce Kwon	-1/+7
	A tree can hold two entries of one name when fsck is off, and the walk went on after the first answered: a second file put two responses in one body, and a directory under the same name printed headers from the mimetype string the first had already freed.
18 hours	Hold a signature download to max-blob-size	Bryce Kwon	-0/+11
	A signature is a note a pusher stored, and the download read it whole without the size check every other blob a page inflates goes through.
18 hours	Lead a snapshot name to its tag ahead of a branch	Bryce Kwon	-31/+56
	The refs listing offers a tag's snapshot under the stem of its name, and the lookup back from that name settled on whatever ref matched first, so a branch spelled like the stem was archived in the tag's place. Every candidate is now tried as a tag before any is tried as a branch.
18 hours	Pass over a notes ref that names no tree	Bryce Kwon	-4/+36
	A pusher can point refs/notes/commits or a signature notes ref at any object, and git dies loading one that is no tree, which ended every page of the repository, the dumb transport included. Such a ref now counts as absent.
18 hours	Show an odd pushed date rather than die on it	Bryce Kwon	-5/+23
	A date past what the system holds, a zone that is no hhmm offset, or a date earlier than its own westward offset all made git die inside show_date, which took the summary, refs, log, commit and feed pages of the repository down. They are now clamped as git's own log clamps them.
18 hours	Check the id before the page chrome resolves it	Bryce Kwon	-0/+4
	The chrome renders on an error page too, where the id had just been refused for using the wider revision syntax, and then looked it up anyway. A :/pattern id walks the whole history for a match.
18 hours	Serve only the files a dumb clone asks for	Bryce Kwon	-16/+21
	The object path check let any run of safe characters through, so a spelling such as info//alternates or info/./alternates reached the alternates file the exact name was refused for. Only a loose object, a pack with its index and info/http-alternates are served now, and any other path is not found.
18 hours	Compress xz snapshots on one thread	Bryce Kwon	-1/+2
	Current xz uses a thread per core unless told otherwise, so a single tar.xz request could keep every core busy, unlike the other compressors.
18 hours	Diff without asking xdiff for a minimal result	Bryce Kwon	-1/+3
	XDF_NEED_MINIMAL turns off the cost limit in xdiff, so a file whose lines were reordered took time quadratic in its length: 2.1 s for one of 40000 lines, now 38 ms. Git leaves it off by default as well.
18 hours	Search the log literally as intended	Bryce Kwon	-6/+4
	setup_revisions compiles the pattern itself, and the literal type cgit set afterwards came too late, so text that was no valid regular expression, such as an unbalanced bracket, ended in a 500.
22 hours	Run a config comment to the end of its line	Bryce Kwon	-1/+1
	skip_line stopped at a NUL as well as at a newline, so the rest of the comment after one was read as a setting.
22 hours	Give a repository without a path no age	Bryce Kwon	-0/+6
	The index built its paths from a NULL repo.path, which the C library prints as "(null)", so it looked for refs under that name in the working directory.
22 hours	End a long directory chain on its last link	Bryce Kwon	-1/+2
	Past fifteen single directories the row stopped after writing the next separator, which left it ending in a dangling " / ".
22 hours	Show an absolute link target as text	Bryce Kwon	-3/+4
	A symlink to /etc/passwd was resolved against the tree and linked to etc/passwd inside it, a different file or none at all.
22 hours	Find a compressor on the default path when unset	Bryce Kwon	-2/+14
	With no PATH in the environment, the check that a compressor exists gave up and refused every compressed snapshot, though execvp would have found it on the system's default path.
22 hours	Keep snapshot members from starting at a slash	Bryce Kwon	-1/+9
	A name that was all suffix, such as .tar, settled on a ref called v with an empty prefix, and an empty snapshot-prefix did the same for a snapshot asked for by id, so every member of the archive started at /.
22 hours	Say why an oversized readme leaves about empty	Bryce Kwon	-3/+16
	A readme past max-blob-size is never read, which left the about page with an empty block and no word of why.
22 hours	Offer tag snapshots only for a tagged commit	Bryce Kwon	-5/+9
	The tag page offered a download for a tag of a tree or a blob, which only led to a "Not a commit" page. The refs listing already checks.
22 hours	Refuse pathspec magic in the feed as in the log	Bryce Kwon	-0/+8
	A feed path starting with a colon reached git as pathspec magic, so an unknown magic word ended the request in a 500 and a known one changed what the path matched, while the log answers both with a 400.
22 hours	Date a reftable repository on the index	Bryce Kwon	-0/+10
	The idle column falls back on the mtime of the branch's loose ref or of packed-refs, and a reftable repository has neither, so its cell stayed empty. Git rewrites reftable/tables.list on every ref update.
22 hours	Answer dumb-clone HEAD from the ref store	Bryce Kwon	-5/+27
	A reftable repository keeps only a placeholder in its HEAD file, so a dumb clone was told HEAD named refs/heads/.invalid and checked nothing out. HEAD is now answered the way git's http-backend answers it.
22 hours	Make two branch conditions say what they rely on	Bryce Kwon	-2/+2
	cgit_parse_url tested ctx.repo where the loop sets repo_end alongside it, and the log's closing link kept a commit it never read. Clang's analyzer tripped on both.
22 hours	Close the tree row when a link target is unreadable	Bryce Kwon	-10/+14
	The row stopped at the error and left its cells open, so the rest of the listing rendered inside it.
22 hours	Correct three comments that drifted from the code	Bryce Kwon	-6/+7
22 hours	Cut text between characters, never inside one	Bryce Kwon	-9/+10
	The index description was cut at a byte count, which could split a multibyte character and leave an invalid sequence on the page. Commit subjects already backed up to the start of the character, so html_ntxt now does that for every caller.
22 hours	Check cgit under sparse in its own dialect	Bryce Kwon	-1/+3
	The sparse rule put git's SPARSE_FLAGS last, and their -std=gnu99 overrode the gnu17 the sources are built as.
22 hours	Drop the NO_C99_FORMAT switch nothing reads	Bryce Kwon	-4/+0
	Neither cgit nor the bundled Git reads the macro it defined.
22 hours	Find libc's write when git writes first	Bryce Kwon	-0/+4
	A Lua build replaces write, and git can write before cmd_main reaches cgit_init_filters, as it does when GIT_TRACE2 is set, which called through a null pointer and crashed every request.
22 hours	Read a negative ref count as no limit	Bryce Kwon	-5/+3
	summary-branches, summary-tags and max-ref-count already listed every ref at 0, but a negative value reached qsort as a count and crashed the summary and refs pages, and emptied the branch switcher.
22 hours	Page a followed log by the name asked for	Bryce Kwon	-5/+6
	Each row of a followed log moves ctx.qry.vpath to the name its commit knew the file by, and the pager built its links from that, so past a rename both links named the old file and led to an empty page.
22 hours	Show the root commit in a followed log	Bryce Kwon	-13/+12
	A followed log diffs each commit against its parent to learn whether the file changed there, and a root commit was skipped rather than diffed against the empty tree, so a file created in the first commit never showed that commit.
22 hours	Peel an annotated tag before looking for a readme	Bryce Kwon	-0/+1
	Tag links carry the tag name as the head, so on any page reached from an annotated tag the about tab vanished and the about page redirected to the summary.
22 hours	Encode repository urls and the feed branch	Bryce Kwon	-25/+53
	Links built from the repository url, among them the description link on the index and the Atom and refs links, wrote it as configured, so a name holding a space, '#' or '?' broke them. The feed link in the page head did the same with the branch, which turned a '+' into a space.
22 hours	Hold object sizes in size_t as git 2.55 does	Bryce Kwon	-37/+37
	Git 2.55 moved object sizes from unsigned long to size_t. The two are the same type on 64-bit hosts, but not on a 32-bit one, where GCC 14 rejects the mismatched pointers, so cgit stopped compiling there.
36 hours	Name every Lua filter failure in the log	Bryce Kwon	-9/+17
	A script raising anything but a string handed die a null to print, and a Lua state that could not be created was used anyway once the filter closed.
36 hours	Let a Lua script write while it loads	Bryce Kwon	-2/+6
	A script's top level runs before cgit hooks stdout for it, and the unhook html() began with tripped an assert that aborted cgit.
36 hours	Detect Lua 5.5 when building	Bryce Kwon	-1/+1
	cgit builds against Lua 5.5 and serves the same pages with it, but a host whose only Lua was 5.5 got a binary without Lua from the search.
38 hours	Give an empty repository's clone table its hooks	Bryce Kwon	-3/+3
	It was a bare table.list with no name, section or label, the one listing that broke what the README promises a theme.
38 hours	Hand the about filter the tree url its links need	Bryce Kwon	-30/+81
	With nothing below the about page, a readme's relative links have to be written against the tree, and only cgit knows how this site spells the url of a tree page and which ref the readme was read from. Both reach the filter already escaped for a url, built by the same writer as cgit's own links.
38 hours	Answer 404 for any path below the about page	Bryce Kwon	-120/+21
	The about page served every file beside the readme as a page of its own, through the about filter, and answered 200 for directories and missing files alike. Images it passed through came from the root of the default branch whatever the readme's own directory and ref. A readme on disk exposed its whole directory this way.
38 hours	Indent continuation lines with one tab	Bryce Kwon	-7/+7
38 hours	Share the max-blob-size check and its refusal	Bryce Kwon	-27/+35
	Five copies of the test and four of the error page had to agree by hand. The new check pins the four refusals, which no test covered.
38 hours	Mark the parameters callbacks leave unused	Bryce Kwon	-6/+6
	With these and the two changes before them, cgit builds under git's DEVELOPER=1 settings, which also annotate their own callbacks this way.
38 hours	Pass callbacks to git by address	Bryce Kwon	-8/+20
	ISO C has no conversion between a function pointer and void *, so the callbacks handed through git's data pointers and the write found by dlsym stopped the pedantic half of a DEVELOPER=1 build.