Age	Commit message (Collapse)	Author	Lines
9 days	Log the path of a repository that will not open	Bryce Kwon	-0/+9
	The 404 page names only the repository and nothing reached the log, so a mistyped repo.path left no trace of the path cgit had tried.
9 days	Read the description file without repo.desc	Bryce Kwon	-14/+39
	Only a scanned repository fell back to its description file, so one listed in cgitrc without repo.desc showed "[no description]" however its file read. repo.desc may follow repo.path, so the file is read where a page shows the description, which also spares every other request the reads.
9 days	Report a word where cgitrc expects a number	Bryce Kwon	-70/+136
	atoi reads "yes" or "true" as 0, so repo.hide=yes, or cgit.hide true in a scanned repository's git config, silently did nothing. The values keep that meaning, since honouring them now would hide repositories on upgrade, but each one is logged with its file and line.
9 days	Report a cgitrc or include that cannot be read	Bryce Kwon	-6/+33
	A missing or unreadable cgitrc left only "No repositories found" and an empty log, the commonest first mistake with no trace of its cause. A scanned repository's own cgitrc stays quiet, since most have none.
9 days	Keep a scan with a negative ttl for good	Bryce Kwon	-1/+2
	"The cache" promises that a negative ttl never expires, but no age was ever below a negative cache-scan-ttl, so every request started a background rescan.
9 days	List scanned repositories in path order	Bryce Kwon	-4/+14
	readdir hands entries back in whatever order the filesystem keeps them, so proj111 could come before proj105 and a section could start twice. section-sort is off by default to keep the order written in cgitrc, and a scan has none to keep.
9 days	Key the cached scan on every setting it uses	Bryce Kwon	-5/+59
	Two cgitrc files sharing a cache-root read one list, so strict-export and trust-scan-config set in one applied to the other, and a changed setting stayed stale until the list expired. The first request after an upgrade scans again, and the files under the old names are never read.
9 days	Log an owner lookup only when it fails	Bryce Kwon	-2/+6
	getpwuid leaves errno alone for a uid with no passwd entry, so a scan logged "Unable to read the owner" with "Success" as the reason for each repository such a uid owns.
9 days	Reset the repository title before reusing it	Bryce Kwon	-1/+3
9 days	Release only finished walks, never cgit's mailmap	Bryce Kwon	-4/+4
	release_revisions frees revs->mailmap, and the log page points it at the static list cgit_mailmap returns, so every log of a repository with enable-mailmap aborted. A walk whose setup failed holds commits that are already freed, so releasing it could free them twice.
9 days	Find Lua under the BSDs' package names	Bryce Kwon	-1/+4
9 days	Keep the repository title in one static buffer	Bryce Kwon	-2/+6
9 days	Free the revision walks' arguments and state	Bryce Kwon	-6/+13
9 days	Spell non-zero the way the rest of the tree does	Bryce Kwon	-1/+1
9 days	Drop a query value check that cannot fire	Bryce Kwon	-3/+0
9 days	Check a ref path without copying it	Bryce Kwon	-10/+4
9 days	Share one lock-file helper between the caches	Bryce Kwon	-64/+58
9 days	Keep the script name local to prepare_context	Bryce Kwon	-5/+1
9 days	Print line number anchors through one helper	Bryce Kwon	-39/+31
9 days	Print the commit and tag dates through one helper	Bryce Kwon	-10/+21
9 days	Print each person through one helper	Bryce Kwon	-44/+30
	The log, refs and tag pages no longer open a filter of their own, so they stop including filter.h.
9 days	Refuse pathspec magic through one helper	Bryce Kwon	-21/+19
9 days	Start each history walk through one helper	Bryce Kwon	-18/+20
9 days	Order shared.c the way shared.h declares it	Bryce Kwon	-147/+144
	The header's blob and pathspec checks move after the diff wrappers so each group reads as one, and each static helper now sits directly above its only user.
9 days	Free commit and tag records beside their parsers	Bryce Kwon	-34/+30
	With the frees gone from shared.h, five page files need nothing else from it, so they stop including it.
9 days	Keep the cache's trailing slash helper in cache.c	Bryce Kwon	-10/+12
9 days	Move cgit.c's own helpers out of shared.c	Bryce Kwon	-86/+78
9 days	Move the mimetype lookup into ui-plain.c	Bryce Kwon	-52/+50
9 days	Move the ref list code into ui-refs.c	Bryce Kwon	-88/+85
9 days	Move the die wrappers into filter.c	Bryce Kwon	-34/+30
10 days	Drop the hidden form fields' unused page argument	Bryce Kwon	-6/+6
10 days	Leave the log's history simplification to git	Bryce Kwon	-1/+0
10 days	Spell the version banner cgit	Bryce Kwon	-1/+1
10 days	Build a literal pathspec in one place	Bryce Kwon	-62/+35
	Git's pathspec item holds a const string now, so a path needs no writable copy to be matched.
10 days	Look up a request's commit in one place	Bryce Kwon	-88/+56
	The diff page now names a revision that is no commit the way the request wrote it, as the other pages already did, rather than as the full id it resolved to. The helpers sit beside the error page in ui-shared.c, since shared.c prints nothing.
10 days	Count the log's columns in ui-log.c alone	Bryce Kwon	-22/+21
10 days	Spell the signature suffix once for both files	Bryce Kwon	-4/+5
10 days	Drop ui-blob's constant file_only arguments	Bryce Kwon	-13/+13
10 days	Keep a commit's encoding local to its parser	Bryce Kwon	-11/+11
10 days	Keep the query string parser beside its one caller	Bryce Kwon	-19/+17
10 days	Drop cgit_read_first_line's unread size output	Bryce Kwon	-9/+5
10 days	Inline the repository list's description link	Bryce Kwon	-24/+4
10 days	Return nothing from html_include	Bryce Kwon	-15/+4
	No caller reads the result, and a void html_include fits the Lua binding's callback as it is, so the wrapper that dropped it goes too.
10 days	Open and close each page through the layout calls	Bryce Kwon	-51/+37
10 days	Sort with git's QSORT	Bryce Kwon	-21/+9
	QSORT skips a list of fewer than two entries, so an empty list's null base never reaches qsort, which is what cgit_qsort was written for.
10 days	Allocate formatted strings with git's xstrfmt	Bryce Kwon	-30/+15
10 days	Let go of a slot lock that cannot take its key	Bryce Kwon	-0/+3
	A failed truncate or key write returned with the descriptor still open, so the lock was held while the page rendered uncached and the file was left behind. It is removed before its last close, as every holder does.
10 days	Keep lock contention out of the error log	Bryce Kwon	-11/+25
	process_slot logged every failure to lock, so each request that found its slot being filled left a line, while refresh_slot logged none, so an expired slot in a directory the server cannot write was served stale for good without a word. lock_slot now logs the step that failed, as the scan does, and leaves out only another request at work.
10 days	Lock the cached repolist with flock	Bryce Kwon	-9/+4
	The slot lock has to be an flock, since an exec filter drops a record lock when it closes the stdout a fill writes through. The scan only got by with fcntl because nothing reopens its file while it runs. One kind of lock lets the two share their code, and on Linux, where the kinds never see each other, an flock on the scan's file now holds a scan off like any other.
10 days	Open the lock files close-on-exec	Bryce Kwon	-2/+4
	Each exec filter and snapshot compressor a fill runs inherited the slot's lock descriptor beside the stdout it writes into. An flock lasts until its last copy closes and nothing waits for a process a filter leaves behind, so a fill killed before its rename could leave the slot locked, and served stale or uncached, for as long as such a process lived. The scan holds its lock across no exec and opens the same way so that the two stay alike.