Age	Commit message (Collapse)	Author	Lines
24 hours	Let go of a slot lock that cannot take its key	Bryce Kwon	-0/+3
	A failed truncate or key write returned with the descriptor still open, so the lock was held while the page rendered uncached and the file was left behind. It is removed before its last close, as every holder does.
24 hours	Keep lock contention out of the error log	Bryce Kwon	-11/+25
	process_slot logged every failure to lock, so each request that found its slot being filled left a line, while refresh_slot logged none, so an expired slot in a directory the server cannot write was served stale for good without a word. lock_slot now logs the step that failed, as the scan does, and leaves out only another request at work.
24 hours	Lock the cached repolist with flock	Bryce Kwon	-9/+4
	The slot lock has to be an flock, since an exec filter drops a record lock when it closes the stdout a fill writes through. The scan only got by with fcntl because nothing reopens its file while it runs. One kind of lock lets the two share their code, and on Linux, where the kinds never see each other, an flock on the scan's file now holds a scan off like any other.
24 hours	Open the lock files close-on-exec	Bryce Kwon	-2/+4
	Each exec filter and snapshot compressor a fill runs inherited the slot's lock descriptor beside the stdout it writes into. An flock lasts until its last copy closes and nothing waits for a process a filter leaves behind, so a fill killed before its rename could leave the slot locked, and served stale or uncached, for as long as such a process lived. The scan holds its lock across no exec and opens the same way so that the two stay alike.
25 hours	Declare the repository variables' struct in place	Bryce Kwon	-6/+4
25 hours	Build cgit_ensure_end's copy in one expression	Bryce Kwon	-9/+1
25 hours	Leave the zeroed repository fields to the memset	Bryce Kwon	-3/+0
25 hours	Grow the repository and ref lists with ALLOC_GROW	Bryce Kwon	-24/+6
25 hours	Join a diff line's pieces within one call	Bryce Kwon	-32/+8
	Xdiff hands out_line a whole line each time, as the prefix, the record and any no-newline marker, and the fragment was already flushed before the call returned, so nothing ever carried over to the next call.
25 hours	Cut two comments that repeat the header or a name	Bryce Kwon	-5/+3
25 hours	Explain the encoded ampersand and plus at the table	Bryce Kwon	-6/+5
25 hours	Map the markup characters to entities in one place	Bryce Kwon	-28/+34
25 hours	Keep the permission triplet beside its one caller	Bryce Kwon	-13/+8
25 hours	Keep the clone row and title docs in the header	Bryce Kwon	-11/+15
25 hours	Keep three helpers beside their only callers	Bryce Kwon	-62/+62
25 hours	Build cgit_date_mode's result on the stack	Bryce Kwon	-2/+1
25 hours	Write the meta description in one place	Bryce Kwon	-6/+4
25 hours	Read a title's path from the end with strrchr	Bryce Kwon	-20/+7
25 hours	Trim trailing slashes with git's strbuf helper	Bryce Kwon	-12/+4
25 hours	Build the full current url from the current url	Bryce Kwon	-8/+3
25 hours	Fold the va_list error page into its one caller	Bryce Kwon	-13/+4
25 hours	Ask head_is_named before carrying the branch	Bryce Kwon	-1/+1
25 hours	Let self_link's fallback be a plain reporevlink	Bryce Kwon	-8/+2
25 hours	Escape a submodule link's class like the others	Bryce Kwon	-6/+6
25 hours	Open site and repository links through one helper	Bryce Kwon	-24/+17
25 hours	Write each query argument through one helper	Bryce Kwon	-49/+30
25 hours	Return repolink's delimiter without copying it	Bryce Kwon	-1/+1
25 hours	Drop the query-string form of every link	Bryce Kwon	-86/+31
	cgit falls back to SCRIPT_NAME for virtual_root whenever cgitrc leaves it out, so the ?url= and ?r= forms only ever reached an error page raised while cgitrc was still being read. The page argument of cgit_add_hidden_formfields fed only the url field, so it is unused until its callers stop passing it.
25 hours	Stop leaking the host on an embedded page	Bryce Kwon	-3/+3
25 hours	Stop leaking the short hash of an object link	Bryce Kwon	-7/+4
25 hours	Trim a snapshot name without reading out of bounds	Bryce Kwon	-29/+12
	For a url of .git, or an empty one, repo_basename stepped its index to the byte before its buffer, read it, and would have cleared it had it held a slash. Git's strbuf trims take the same steps safely, and they lift the 1024-byte cap that failed the page for a longer url.
25 hours	Drop two includes nothing in their files uses	Bryce Kwon	-3/+0
25 hours	Give stdout back from a slot in one place	Bryce Kwon	-10/+11
25 hours	Use the parser's INT_MAX for every snapshot format	Bryce Kwon	-5/+1
	The snapshots parser already answers all with INT_MAX, so cgit.c needed no value of its own for the same mask.
25 hours	Hand back the fallback branch rather than a copy	Bryce Kwon	-13/+4
25 hours	Drop dead checks and a repeated filter cleanup	Bryce Kwon	-12/+7
	build_snapshot_setting always returns a buffer, both commit-sort values are tested on their own, authenticate_post ends the process, and the filters are cleaned up by the atexit handler once cmd_main returns.
25 hours	Cap the search with xstrndup alone	Bryce Kwon	-4/+1
25 hours	Return nothing from two calls nobody checks	Bryce Kwon	-9/+7
25 hours	Drop reencode's fixed target and unread result	Bryce Kwon	-12/+11
	Every call converted into the page encoding and dropped what came back, and a commit's encoding is always set by the time it runs.
25 hours	Rename prepare_repo_env to open_repo	Bryce Kwon	-2/+2
	It opens the repository and loads its notes, while cgit_prepare_repo_env exports the CGIT_REPO_ variables, and the two names were one prefix apart.
25 hours	Explain the notes setup in one comment	Bryce Kwon	-4/+3
25 hours	Leave the scan's summary to its header	Bryce Kwon	-7/+3
25 hours	Drop the scan's redundant stats and one-pass loop	Bryce Kwon	-12/+11
	The description and cgitrc readers already return when the file will not open, a repository's description is never NULL before it is read, and the owner lookup never went round a second time.
25 hours	Strip a scanned path's suffixes with git's helpers	Bryce Kwon	-10/+7
25 hours	Give the Lua-less filter init the Lua block's else	Bryce Kwon	-6/+4
25 hours	Allocate the filters zeroed with xcalloc	Bryce Kwon	-7/+2
25 hours	Drop the exec filter's close steps that do nothing	Bryce Kwon	-7/+1
	A filter is only closed after an open has forked it, so its pid is a child's, and every open writes its arguments into argv afresh.
25 hours	Format the cache listing's times where it prints	Bryce Kwon	-17/+6
25 hours	Close the cache's descriptors through one helper	Bryce Kwon	-33/+15
25 hours	Drop the cache's checks for arguments never NULL	Bryce Kwon	-14/+0
	The cache root always holds a default or a copy, the key comes from a strbuf, and every string hashed is the same or a macro expansion.