| Age | Commit message (Collapse) | Author | Lines |
|---|---|---|---|
| Sort an empty list without handing qsort a null | Bryce Kwon | -1/+1 | |
| Every list sorted here is null until its first entry, and C leaves a null base undefined even with nothing to sort. glibc declares it nonnull and its UBSan build aborted the stats page of a repository with no commits in the window, which the Linux matrix caught. | |||
| Hold a scanned defbranch to a ref name | Bryce Kwon | -1/+3 | |
| The index stats the default branch below the repository to date it, and a scanned repository sets its own defbranch, which was not held to what a ref may hold, so one spelled as a path reached a file outside. | |||
| Give a repository without a path no age | Bryce Kwon | -0/+6 | |
| The index built its paths from a NULL repo.path, which the C library prints as "(null)", so it looked for refs under that name in the working directory. | |||
| Date a reftable repository on the index | Bryce Kwon | -0/+10 | |
| The idle column falls back on the mtime of the branch's loose ref or of packed-refs, and a reftable repository has neither, so its cell stayed empty. Git rewrites reftable/tables.list on every ref update. | |||
| Hand the about filter the tree url its links need | Bryce Kwon | -1/+1 | |
| With nothing below the about page, a readme's relative links have to be written against the tree, and only cgit knows how this site spells the url of a tree page and which ref the readme was read from. Both reach the filter already escaped for a url, built by the same writer as cgit's own links. | |||
| Indent continuation lines with one tab | Bryce Kwon | -1/+1 | |
| Keep string literals behind const pointers | Bryce Kwon | -4/+4 | |
| Git's DEVELOPER=1 build turns on -Wwrite-strings as an error, and the literals stored through plain char pointers failed cgit's own objects there. The exec filter's argv takes the cast execvp needs once, the way git's run-command does. | |||
| Add stable markup hooks for site themes | Bryce Kwon | -7/+10 | |
| Harden the page renderers | Bryce Kwon | -4/+7 | |
| Clean up the whole tree | Bryce Kwon | -12/+6 | |
| Trim the comments and dead code across the tree | Bryce Kwon | -3/+2 | |
| Use standard HTTP reason phrases | Bryce Kwon | -1/+1 | |
| Tidy the structure of the generated markup | Bryce Kwon | -5/+5 | |
| Skip the owner link when a repo has no owner | Bryce Kwon | -7/+11 | |
| Let the listings wrap and the diff tables scroll | Bryce Kwon | -1/+1 | |
| Restyle the sources and fix the audit's findings | Bryce Kwon | -159/+204 | |
| Stop the index and the log repeating work | Bryce Kwon | -20/+35 | |
| Settle the names, types and layout of the sources | Bryce Kwon | -2/+2 | |
| Remove the owner filter hook | Bryce Kwon | -5/+1 | |
| Point the fork's links and credits at itself | Bryce Kwon | -1/+1 | |
| AUTHORS now records the upstream developers as the project's history rather than as maintainers of the fork. | |||
| Compare repository idle times by sign | Bryce Kwon | -1/+7 | |
| The idle-sort comparator returned a 64-bit time difference truncated to int, which could flip sign and leave the ordering inconsistent. | |||
| Date repositories from HEAD and guard its branch | Bryce Kwon | -2/+27 | |
| The index derived a repository's age from `refs/heads/master` alone, so a repository on any other default branch showed no age. HEAD is repo-controlled and the age stat walks under `refs/heads`, so a branch name carrying a parent-directory component is rejected. | |||
| Adapt the layout to small screens | Bryce Kwon | -8/+10 | |
| On a phone the description, owner and shortcut columns crowded the index and pushed the age off screen, and tapping the name already opens the repository, so the index collapses to name and age. | |||
| Reorganize into source, assets and libraries | Bryce Kwon | -0/+0 | |
| The C sources move to source/, the served files to assets/, the bundled Git submodule to libraries/git and the filter scripts to extensions/. Everything the build generates now lands in build/, so a clean is a single remove and the tree stays clean. | |||
| cgit: truncate all config values at the newline | Jason A. Donenfeld | -1/+1 | |
| These would be largely invalid anyway (save, I suppose, for Linux file paths that technically can contain new lines). The actual problem is that these get printed back out into cached -- and trusted -- cgitrc files, and if the fields have newlines, the git-config way of less trusted users configuring repos on a shared system can be abused to inject newlines, which then can be used to smuggle global options (including filters, which execute code) into the cached cgitrc. So now, only ever duplicate up to the newline, when dealing with these inputs. Reported-by: Adrian Denkiewicz <adrian@doyensec.com> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> | |||
| ui-repolist,ui-shared: remove redundant title on repo anchors | Chris Mayo | -1/+1 | |
| The title attribute was being set to the same value as the anchor element text. Signed-off-by: Chris Mayo <aklhfex@gmail.com> Reviewed-by: Eric Wong <e@80x24.org> Reviewed-by: Petr Vorel <petr.vorel@gmail.com> Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> | |||
| ui-repolist: do not return unsigned (negative) value | Christian Hesse | -1/+1 | |
| The function read_agefile() returns time_t, which is a signed datatime. We should not return unsigned (negative) value here. Reported-by: Johannes Stezenbach <js@linuxtv.org> Signed-off-by: Christian Hesse <mail@eworm.de> | |||
| global: make 'char *path' const where possible | Christian Hesse | -1/+1 | |
| Signed-off-by: Christian Hesse <mail@eworm.de> | |||
| global: remove functionality we deprecated for cgit v1.0 | Christian Hesse | -3/+0 | |
| The man page states these were deprecated for v1.0. We are past v1.1, so remove the functionality. Signed-off-by: Christian Hesse <mail@eworm.de> Reviewed-by: John Keeping <john@keeping.me.uk> | |||
| html: html_ntxt with no ellipsis | Jeff Smith | -1/+2 | |
| For implementing a ui-blame page, there is need for a function that outputs a selection from a block of text, transformed for HTML output, but with no further modifications or additions. Signed-off-by: Jeff Smith <whydoubt@gmail.com> Reviewed-by: John Keeping <john@keeping.me.uk> | |||
| Remove unused variable from sort_section() | Lukas Fleischer | -1/+0 | |
| Signed-off-by: Lukas Fleischer <lfleischer@lfos.de> | |||
| ui-repolist: properly sort by age | Jason A. Donenfeld | -21/+17 | |
| When empty repos exist, comparing them against an existing repo with a good mtime might, with particular qsort implementations, not sort correctly, because of this brokenness: if (get_repo_modtime(r1, &t) && get_repo_modtime(r2, &t)) However, sorting by the age column works as expected, so anyway, to tidy things up, we simply reuse that function. Signed-off-by: Jason A. Donenfeld <Jason@zx2c4.com> | |||
| css: highlight even table rows and skip empty rows | Christian Hesse | -1/+1 | |
| This is stolen from kernel.org css [0]. [0] https://git.kernel.org/cgit-korg-0.10.1.css | |||
| ui-repolist: fix memory leak | Christian Hesse | -1/+3 | |
| ui-repolist: fix memory leak | Christian Hesse | -1/+4 | |
| ui: show ages in the originator's timezone | John Keeping | -1/+1 | |
| This affects the tooltip showing the full time and the case when a date is sufficiently old to be shown in full rather than as an offset. Signed-off-by: John Keeping <john@keeping.me.uk> | |||
| ui-shared: remove "format" from cgit_print_age() | John Keeping | -1/+1 | |
| We never use any format other than FMT_SHORTDATE, so move that into the function. Signed-off-by: John Keeping <john@keeping.me.uk> | |||
| ui-repolist: return HTTP 404 if no repositories found | Peter Colberg | -3/+17 | |
| Return HTTP status code 404 Not found when querying a non-existent repository, which signals to search engines that a repository no longer exists. Further, some webservers such as nginx permit logging requests to different files depending on the HTTP code. Signed-off-by: Peter Colberg <peter@colberg.org> | |||
| ui-repolist: extract repo visibility criteria to separate function | Peter Colberg | -3/+10 | |
| Signed-off-by: Peter Colberg <peter@colberg.org> | |||
| ui-repolist: initialize char *buf to NULL | Christian Hesse | -1/+1 | |
| readfile() can fail if the agefile is not readable. Make sure free() does not free an ininitialized string. Signed-off-by: Christian Hesse <mail@eworm.de> | |||
| ui-repolist: fix resource leak: free allocation from cgit_currenturl | Christian Hesse | -1/+3 | |
| Coverity-id: 13930 Signed-off-by: Christian Hesse <mail@eworm.de> | |||
| ui-repolist: fix resource leak: free before return | Christian Hesse | -1/+3 | |
| Coverity-id: 13931 Signed-off-by: Christian Hesse <mail@eworm.de> | |||
| about: move layout into page functions | John Keeping | -1/+4 | |
| Signed-off-by: John Keeping <john@keeping.me.uk> | |||
| Remove redundant includes | John Keeping | -1/+0 | |
| These are all included in git-compat-util.h (when necessary), which we include in cgit.h. Signed-off-by: John Keeping <john@keeping.me.uk> | |||
| log: allow users to follow a file | John Keeping | -1/+1 | |
| Teach the "log" UI to behave in the same way as "git log --follow", when given a suitable instruction by the user. The default behaviour remains to show the log without following renames, but the follow behaviour can be activated by following a link in the page header. Follow is not the default because outputting merges in follow mode is tricky ("git log --follow" will not show merges). We also disable the graph in follow mode because the commit graph is not simplified so we end up with frequent gaps in the graph and many lines that do not connect with any commits we're actually showing. We also teach the "diff" and "commit" UIs to respect the follow flag on URLs, causing the single-file version of these UIs to detect renames. This feature is needed only for commits that rename the path we're interested in. For commits before the file has been renamed (i.e. that appear later in the log list) we change the file path in the links from the log to point to the old name; this means that links to commits always limit by the path known to that commit. If we didn't do this we would need to walk down the log diff'ing every commit whenever we want to show a commit. The drawback is that the "Log" link in the top bar of such a page links to the log limited by the old name, so it will only show pre-rename commits. I consider this a reasonable trade-off since the "Back" button still works and the log matches the path displayed in the top bar. Since following renames requires running diff on every commit we consider, I've added a knob to the configuration file to globally enable/disable this feature. Note that we may consider a large number of commits the revision walking machinery no longer performs any path limitation so we have to examine every commit until we find a page full of commits that affect the target path or something related to it. Suggested-by: René Neumann <necoro@necoro.eu> Signed-off-by: John Keeping <john@keeping.me.uk> | |||
| ui-repolist: make sortcolumn definitions 'static const' | John Keeping | -2/+2 | |
| These are not used outside this file and are not declared; they are also never modified. Signed-off-by: John Keeping <john@keeping.me.uk> | |||
| Avoid non-ANSI function declarations | John Keeping | -3/+3 | |
| Sparse says things like: warning: non-ANSI function declaration of function 'calc_ttl' Signed-off-by: John Keeping <john@keeping.me.uk> | |||
| Make root handling sane again. | Jason A. Donenfeld | -1/+1 | |
| ui-shared: Add current url helper function. | Jason A. Donenfeld | -2/+2 | |
| ui-repolist: use ctx.qry.url instead of rooturl, in case we're filtering | Jason A. Donenfeld | -2/+2 | |
index : cgit
Hyperfast and read-only web frontend for git repositories
Bryce Kwon