AgeCommit message (Collapse)AuthorLines
Check the submodule pin against the MakefileBryce Kwon-2/+3
The commit named is the one Git's v2.56.0 tag peels to upstream.
Say which test checks the login form hooksBryce Kwon-1/+3
Pass further release build arguments on to makeBryce Kwon-4/+5
The release build took lua alone, so its binary could not be tested as built, and a Mac without pkg-config could not name LuaJIT for it.
Show the Git version checks as skipped, not passedBryce Kwon-2/+3
CGIT_TEST_NO_GIT_VERSION ended t0001 before the test library started, so it wrote no counts and printed nothing. Without vendor/git/.git the submodule check passed with a note on stderr, which is the case for a tree from get-git or git archive, so the pin was checked nowhere.
Check the Lua-less build through the helpersBryce Kwon-1/+2
t0006 ran build/nolua/cgit by its path, so Valgrind never saw it, and its page checks passed a page that logged an error. The Makefile and README said the suite runs both binaries the same way, though only these four tests run the one without Lua.
Keep cgit under Valgrind whichever way it is askedBryce Kwon-2/+4
The library runs a script again for --tee, --verbose-log and --stress with the arguments setup.sh left it, and --valgrind was no longer among them, so -V --valgrind ran cgit bare. --valgrind=<tool> reached the library instead, which then wrapped every Git command and left cgit alone. --valgrind-only is refused, as it would need the library's own per-test switching.
Let a test run require the tools it must not skipBryce Kwon-0/+10
Nothing could make a missing prerequisite fail. A host without pkg-config builds without Lua, and make test then passed with every Lua test skipped and the lua pass of t0201 never run. The whole-script skips become named prerequisites so the same list covers them, and the strace probe now traces the file class of calls the tests use, so an strace too old for it skips rather than fails.
Describe how to run the tests in READMEBryce Kwon-0/+35
Only the source tree list mentioned the suite, so nothing said how to run one script, pass options or see why a test failed, or which tools the skipped tests want.
Describe the drop-in server configs in READMEBryce Kwon-5/+8
Allow a luaossl patched for Lua 5.5Bryce Kwon-2/+2
List every case the login error coversBryce Kwon-2/+4
List the options renamed since upstream cgitBryce Kwon-0/+22
List a theme after cgit.cssBryce Kwon-0/+8
Any css or js line replaces the default rather than adding to it, so a theme set with a single css line, as the README implied, left every page unstyled.
Say the auth filters need /var/lib/cgitBryce Kwon-0/+4
Map the source tree in the READMEBryce Kwon-0/+15
Turn the setup notes into a quick startBryce Kwon-10/+30
Say that make install builds againBryce Kwon-1/+8
Show the cgit.conf the server configs expectBryce Kwon-2/+9
Name the packages the build needsBryce Kwon-5/+11
Write five compound terms one way in the docsBryce Kwon-3/+3
Each takes the form its option name or most of the prose already uses, as in case-sensitive-sort and side-by-side-diffs.
Spell url the way the tree mostly doesBryce Kwon-1/+1
Names keep their own spelling, so the URL trailer and CGIT_REPO_URL stay in capitals.
Say the highlighter needs Scintillua's detect()Bryce Kwon-1/+1
Spell customisation and uncoloured the British wayBryce Kwon-1/+1
Fetch the Git submodule in one commandBryce Kwon-4/+2
Document virtual-root's default of SCRIPT_NAMEBryce Kwon-2/+2
cgit falls back to SCRIPT_NAME followed by a slash when virtual-root is unset, so its links always take the path form and none take the ?url= form the docs described.
Credit Git in the READMEBryce Kwon-0/+4
Stop folding a tag's signature awayBryce Kwon-2/+0
The fold put a click between the reader and the signature, and the browser's own disclosure marker and summary did not take the theme. The signature prints as part of the message again, as it did up to v2.9.1.
Fold a tag's signature away under its messageBryce Kwon-0/+2
The armour ran on for more lines than most tag messages, as part of the message itself. git finds the signature for every kind it can sign with, so PGP, SSH and X.509 all fold the same way.
Say when a login fails, and line up the formBryce Kwon-0/+2
A wrong password sent the reader back to the same empty form, which looked no different from a crash. The redirect now carries a flag the form reads, the same for an unknown user as for a wrong password, and the form leaves the flag out of the way back it signs.
Show characters a browser breaks at as escapesBryce Kwon-0/+3
The HTML parser turns a carriage return with no line feed after it into a line feed, and WebKit starts a new line at U+2028 and U+2029, while git and the line numbers count line feeds alone, so each one set every later line of the tree and blame pages a line below its number. CSS Text makes vertical tab, form feed and next line forced breaks as well, though no engine honours that yet. The escapes follow gitweb, which shows control characters the same way.
Say how to build cgit on muslBryce Kwon-0/+6
Git's code there needs the kernel headers and its bundled regex, and the build failed with nothing to say so.
Build Git without translations or Tcl toolsBryce Kwon-2/+2
cgit never shows Git's translations or runs its Tcl tools, yet building needed libintl and msgfmt for one and, under make test, tclsh for the other, which a minimal system may lack.
Claim and test Lua 5.5 for every extensionBryce Kwon-2/+2
luaossl from release 20260910 and luaposix load under Lua 5.5, and cgit renders the same pages under it as under LuaJIT. Running the suites there already caught a write to a for loop's control variable, which 5.5 makes read-only.
Detect Lua 5.5 when buildingBryce Kwon-3/+3
cgit builds against Lua 5.5 and serves the same pages with it, but a host whose only Lua was 5.5 got a binary without Lua from the search.
Give an empty repository's clone table its hooksBryce Kwon-4/+5
It was a bare table.list with no name, section or label, the one listing that broke what the README promises a theme.
Check every markup hook the README namesBryce Kwon-8/+11
The README promised that t0005 checked them all, while fourteen went unchecked, and three of its claims were too broad. A date shown in full carries no age hooks, line anchors follow enable-tree-linenumbers and cgit.css also styles html.cgit-standalone.
Complete the README's pages and query parametersBryce Kwon-3/+14
List everything make install puts in placeBryce Kwon-3/+4
Walk a path on the blob page from a commit idBryce Kwon-1/+1
With both an id and a path the blob page handed back the raw object the id named, so a commit id gave the commit text itself, while the plain page looked the path up in that commit's tree. A tag is peeled to its commit on the way, and the README example of a pinned commit now uses a form the request checks accept.
Keep the Lua-less build compilingBryce Kwon-0/+5
cgit_abort_filters unhooks the Lua write interposer under NO_LUA too, where neither the hook nor its state exists, so make NO_LUA=1 and the default mode of tools/release-build.sh have not compiled since the die path learned to take stdout back from a filter. The suite now builds and runs that variant as well, and a lua: filter in such a build is refused with a message naming the cause instead of an unknown filter type.
Add stable markup hooks for site themesBryce Kwon-0/+45
Unify the docs, samples and extensionsBryce Kwon-32/+25
Split trailers out of the commit messageBryce Kwon-1/+1
Trim README and fold in the author creditsBryce Kwon-122/+52
Document the line anchors in READMEBryce Kwon-0/+5
Convert the manual page to plain MANUAL.txtBryce Kwon-2/+2
Beyond the format change, the documented defaults and inheritance notes now match what the code does.
Tabulate the query parameters in the readmeBryce Kwon-24/+24
Fold the test README and .gitignore into the rootBryce Kwon-52/+65
Document how cgit urls are builtBryce Kwon-0/+65
Drop the Last-Modified, Expires and ETag headersBryce Kwon-1/+1