Age	Commit message (Collapse)	Author	Lines
38 hours	Name the auth cookie __Host- where it can be	Bryce Kwon	-30/+71
	Without the prefix any host under the same domain could set a cgitauth cookie of its own, signing a visitor in as someone else or out.
38 hours	End a session when its account's hash changes	Bryce Kwon	-62/+108
	A session stayed good for its whole week after the password changed or the account went away, which is when ending it matters most.
38 hours	Load auth libraries only when a request needs one	Bryce Kwon	-18/+63
	Required at the top, a missing luaossl or luaposix failed every request to the site, public pages included, and each public page paid to load both.
38 hours	Say which hash kinds each system's crypt checks	Bryce Kwon	-4/+27
	The one recipe given, SHA-512 from Debian's mkpasswd, cannot log anyone in on OpenBSD, whose crypt checks only bcrypt, or on macOS, and libxcrypt, which most Linux distributions use, recommends yescrypt instead.
38 hours	Spend a missing account's login on a real hash	Bryce Kwon	-57/+99
	The fixed SHA-512 stand-in matched only the documented setup, so a site hashing with yescrypt, other rounds or bcrypt answered for missing and real names in different times, and on OpenBSD it failed at once.
38 hours	Turn down passwords past 256 bytes unchecked	Bryce Kwon	-2/+32
	SHA-crypt hashes the password in most of its rounds, so the 4 KB that cgit's POST limit lets through cost about fifteen ordinary logins per anonymous attempt.
38 hours	Read the auth cookie in linear time	Bryce Kwon	-14/+52
	Splitting the header with patterns that backtrack over spaces cost a quarter of a second per request at the 8 KB line most web servers allow, and a second at 16 KB, without any login. auth-file's trim had the same shape and now reads the cookie as well.
38 hours	Offer avatars at twice the size to dense screens	Bryce Kwon	-14/+23
	The 13 pixel icon came out blurred on the high density screens most phones and laptops have.
38 hours	Hash avatar addresses with SHA-256	Bryce Kwon	-13/+16
	Gravatar's documentation now describes SHA-256 hashes on gravatar.com alone, and Libravatar has long accepted them beside MD5.
38 hours	Mark avatar icons as decorative	Bryce Kwon	-11/+7
	A screen reader announced the service's name before every author.
38 hours	Unwrap an avatar address in linear time	Bryce Kwon	-6/+19
	An author email of 16,000 "<" took three quarters of a second per log row, and one of 64,000 took twelve seconds.
38 hours	Draw no avatar when luaossl is missing	Bryce Kwon	-15/+41
	The require at the top raised as cgit loaded the filter, so every page that lists an author stopped at its first author cell with an error.
39 hours	Drop the table loop's dead blank-line test	Bryce Kwon	-1/+1
	A line holding a pipe is never blank.
39 hours	Compare the cached page with the uncached one whole	Bryce Kwon	-5/+1
	The footer lost the time it was generated at in 2018, and both runs come from the same binary, so the two pages have nothing to differ in.
39 hours	Give an empty repository's clone table its hooks	Bryce Kwon	-10/+21
	It was a bare table.list with no name, section or label, the one listing that broke what the README promises a theme.
39 hours	Check every markup hook the README names	Bryce Kwon	-8/+84
	The README promised that t0005 checked them all, while fourteen went unchecked, and three of its claims were too broad. A date shown in full carries no age hooks, line anchors follow enable-tree-linenumbers and cgit.css also styles html.cgit-standalone.
39 hours	Complete the README's pages and query parameters	Bryce Kwon	-3/+14
39 hours	List everything make install puts in place	Bryce Kwon	-3/+4
39 hours	Add blame to the source filter and line number docs	Bryce Kwon	-15/+23
39 hours	Name every trailer link-trailers.lua links	Bryce Kwon	-6/+6
39 hours	Say that js may be given more than once	Bryce Kwon	-3/+24
39 hours	Fix the sample cgitrc's defaults and value syntax	Bryce Kwon	-13/+16
39 hours	Add html serving to the scanned cgitrc trust list	Bryce Kwon	-3/+4
	1456483 gated the key and named it under trust-scan-config, but this section kept the list from before.
39 hours	Describe root-readme as the site's about page	Bryce Kwon	-18/+36
39 hours	Say which filters get the repository variables	Bryce Kwon	-1/+15
39 hours	Leave readme out of what scan-path fixes	Bryce Kwon	-3/+15
39 hours	Name the log link that enable-index-links adds	Bryce Kwon	-3/+12
	The manual has named the commit page since it was written in 2008, a year after the index started linking the log instead.
39 hours	Give readme headings anchors like GitHub's	Bryce Kwon	-10/+58
	A readme's links to its own sections, as in a table of contents, had nothing on the page to land on.
39 hours	Keep underscores inside words out of emphasis	Bryce Kwon	-4/+15
39 hours	Let character references through to the browser	Bryce Kwon	-2/+26
	Decoding them here instead would mean carrying every named reference HTML defines, while the browser already knows them all.
39 hours	Honour backslash escapes in readmes	Bryce Kwon	-1/+12
39 hours	Link the urls and addresses in angle brackets	Bryce Kwon	-1/+26
39 hours	Keep a wrapped list item in its list	Bryce Kwon	-8/+29
	The item's second line became a paragraph of its own and the items after it a new list, so an ordered list started counting again.
39 hours	Let a table cut a paragraph short	Bryce Kwon	-2/+18
	A table written right under a line of text came out as more of the paragraph, pipes and all.
39 hours	Run a paragraph's lines together like GitHub	Bryce Kwon	-13/+43
	GitHub shows a single newline in a markdown file as a space, and roff fills the lines of a man page the same way, so text wrapped in the source came out ragged on the about page.
39 hours	Leave images and badges out of rendered readmes	Bryce Kwon	-27/+35
	A relative image loaded from below the about page, which answers 404 now, and a remote one had every visitor's browser call a third party. A badge also came out as a link to its own image, wrapped in stray brackets.
39 hours	Lead a readme's relative links into the tree	Bryce Kwon	-11/+114
	A browser resolved them against the about page, where nothing lives now that the page answers 404 below itself. They resolve the way GitHub resolves a readme's links instead, from the readme's directory and on the branch it was read from.
39 hours	Trim readme lines in linear time	Bryce Kwon	-2/+36
	The heading pattern backtracked over a run of spaces in cubic time and the cell trim in quadratic time, so one crafted line in a readme could hold a request for half an hour, well inside the size cap. The heading rule now also keeps a sharp that ends a word, as in "# C#".
39 hours	Hand the about filter the tree url its links need	Bryce Kwon	-43/+122
	With nothing below the about page, a readme's relative links have to be written against the tree, and only cgit knows how this site spells the url of a tree page and which ref the readme was read from. Both reach the filter already escaped for a url, built by the same writer as cgit's own links.
39 hours	Answer 404 for any path below the about page	Bryce Kwon	-135/+44
	The about page served every file beside the readme as a page of its own, through the about filter, and answered 200 for directories and missing files alike. Images it passed through came from the root of the default branch whatever the readme's own directory and ref. A readme on disk exposed its whole directory this way.
39 hours	Keep the age hook's directory group writable	Bryce Kwon	-2/+31
	The hook forced a 022 umask, so in a repository shared with a group the first pusher owned info/web and every other member's push failed to write the age file there.
39 hours	Keep the cache hook's rm errors from pushers	Bryce Kwon	-4/+38
	Only the exit status was hidden, so a pusher without write access to the cache root saw a permission error per cached page, against what the hook's own comment promised.
39 hours	Trim avatar addresses in linear time	Bryce Kwon	-2/+36
	The trim pattern backtracked over a run of spaces inside an address, which a commit can carry, and a log page runs the filter for every row. Forty thousand spaces took two seconds per row.
39 hours	Refuse every repository when auth-file loses repos	Bryce Kwon	-11/+27
	A repos file the filter could not open read as listing nothing, so a permission slip or a mistyped path made every protected repository public. A line naming a repository with no groups was skipped the same way, where auth-inline's empty list denies everyone.
39 hours	Put then on its own line in the release build	Bryce Kwon	-3/+6
39 hours	Indent continuation lines with one tab	Bryce Kwon	-7/+7
39 hours	Share the max-blob-size check and its refusal	Bryce Kwon	-27/+48
	Five copies of the test and four of the error page had to agree by hand. The new check pins the four refusals, which no test covered.
39 hours	Mark the parameters callbacks leave unused	Bryce Kwon	-6/+6
	With these and the two changes before them, cgit builds under git's DEVELOPER=1 settings, which also annotate their own callbacks this way.
39 hours	Pass callbacks to git by address	Bryce Kwon	-8/+20
	ISO C has no conversion between a function pointer and void *, so the callbacks handed through git's data pointers and the write found by dlsym stopped the pedantic half of a DEVELOPER=1 build.
39 hours	Keep string literals behind const pointers	Bryce Kwon	-59/+53
	Git's DEVELOPER=1 build turns on -Wwrite-strings as an error, and the literals stored through plain char pointers failed cgit's own objects there. The exec filter's argv takes the cast execvp needs once, the way git's run-command does.