| Age | Commit message (Collapse) | Author | Lines |
|
A ref label, email address or path longer than a phone screen pushed
main.content sideways by up to 340px. In the log and summary the label
also widened the shared table until the age column left the screen.
Below 640px a label becomes an inline-block capped at its cell, so it
still moves to the next line whole and breaks inside only when it is
wider than the cell. line-height: normal keeps the box the height of
the inline label it replaces. That holds exactly in Chromium and
Firefox, while WebKit's box grows by a third of a pixel at each edge.
Commit details and diffstat paths break at the cell edge, as listing
cells already do.
|
|
A date in a listing that is not a relative age is a time element with
no age class, so it missed the nowrap the ages get. Wherever a listing
ran short of room the date split at its hyphen, 2026- over 02-13, and
doubled every row. That happened on phones in every engine, and at
768px in Chromium and WebKit.
|
|
|
|
The login page stands in for any page of the repository, so it named
the description and owner of one the visitor may not see, including
one hidden from the index. The site's own description fills the
line, as on the index, so the header keeps its height.
|
|
|
|
|
|
|
|
The tree page read the gitlink's commit as a blob, which outside the
repository is a bad object id and inside it is the commit's raw text.
|
|
|
|
The config error page had a title of its own, in the reverse order,
and now takes the same one as any other 404, since its message
already says the repository failed to open.
|
|
The link named only id, so for a diff between two commits it led to
a patch of the newer one alone, and without an id it lost the branch
as well and led to the default branch's tip.
|
|
The blame page answers 404 for a symlink, since git blames a regular
file alone, and it refuses a binary file and one past max-blob-size,
yet a tree listing offered blame for all of them, and so did a
symlink's own page. Each row already knows its size, and git calls a
file binary by its first 8000 bytes alone, which a stream reads
without inflating the rest. With blame on, a listing of 2,000
delta-packed files went from about 11 to 15 ms.
|
|
|
|
|
|
|
|
The snapshot page refuses to work a revision out of a name holding a
slash, since that name becomes the top directory of the archive, so
every link for a ref like release/2.0 answered 404. The ref now goes
in the link as the id, and the archive unpacks into the repository's
own prefix, as any snapshot asked for by id does.
|
|
A diff limited to the new name cannot see the old one, so the
diffstat's link for a renamed file, the commit page reached from that
file's log, and the file's rawdiff and patch all showed every line as
added. A path the old tree lacks is now diffed across the whole commit
with rename detection aimed at it alone, the way git blame looks for a
rename, so it is compared with the commit's deleted files and nothing
else. Doing it in cgit_diff_tree keeps the log's counts for that commit
in step with the page they link to.
The rawdiff and patch pages leave the diff to git's own output, so for
them that search finds the old name, and both names go into the limit
with rename detection on.
|
|
A LUA_PKGCONFIG that pkg-config could not resolve, with no LUA_LIBS or
LUA_CFLAGS given, still claimed to link with it and then failed on
lua.h, and a build that found no pkg-config dropped Lua with no hint
of why. A warning rather than an error lets the build go on, since
flags supplied another way, such as CGIT_LIBS in cgit.conf, may still
make it link.
|
|
The 404 page names only the repository and nothing reached the log, so
a mistyped repo.path left no trace of the path cgit had tried.
|
|
Only a scanned repository fell back to its description file, so one
listed in cgitrc without repo.desc showed "[no description]" however
its file read. repo.desc may follow repo.path, so the file is read
where a page shows the description, which also spares every other
request the reads.
|
|
atoi reads "yes" or "true" as 0, so repo.hide=yes, or cgit.hide true
in a scanned repository's git config, silently did nothing. The values
keep that meaning, since honouring them now would hide repositories on
upgrade, but each one is logged with its file and line.
|
|
A missing or unreadable cgitrc left only "No repositories found" and an
empty log, the commonest first mistake with no trace of its cause. A
scanned repository's own cgitrc stays quiet, since most have none.
|
|
"The cache" promises that a negative ttl never expires, but no age was
ever below a negative cache-scan-ttl, so every request started a
background rescan.
|
|
readdir hands entries back in whatever order the filesystem keeps
them, so proj111 could come before proj105 and a section could start
twice. section-sort is off by default to keep the order written in
cgitrc, and a scan has none to keep.
|
|
Two cgitrc files sharing a cache-root read one list, so strict-export
and trust-scan-config set in one applied to the other, and a changed
setting stayed stale until the list expired. The first request after
an upgrade scans again, and the files under the old names are never
read.
|
|
|
|
getpwuid leaves errno alone for a uid with no passwd entry, so a scan
logged "Unable to read the owner" with "Success" as the reason for each
repository such a uid owns.
|
|
exec skipped the EXIT trap, so every run left its three probe files in
TMPDIR.
|
|
|
|
|
|
|
|
Both tests passed or failed with the order in which cgit and the exec
filter happened to run, about one run in four under UBSan.
|
|
Scintillua's detect() matches an extension by its case, and the fallback
e227d1f dropped had lowercased it, so MAIN.C and SETUP.PY lost their
colour. The fake lexer now answers only for the suffixes it knows, as
Scintillua does, which is what lets the check see it.
|
|
release_revisions frees revs->mailmap, and the log page points it at the
static list cgit_mailmap returns, so every log of a repository with
enable-mailmap aborted. A walk whose setup failed holds commits that are
already freed, so releasing it could free them twice.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
It asks for a log page, and the index never carries a feed link.
|
|
|
|
|
|
|
|
|
|
The one-line request wrappers go with them. Configs with several
repositories, a key out of place on purpose, the cache on or no
repository of their own stay written out.
|