| Age | Commit message (Collapse) | Author | Lines |
|
|
|
|
|
The snapshot page refuses to work a revision out of a name holding a
slash, since that name becomes the top directory of the archive, so
every link for a ref like release/2.0 answered 404. The ref now goes
in the link as the id, and the archive unpacks into the repository's
own prefix, as any snapshot asked for by id does.
|
|
A diff limited to the new name cannot see the old one, so the
diffstat's link for a renamed file, the commit page reached from that
file's log, and the file's rawdiff and patch all showed every line as
added. A path the old tree lacks is now diffed across the whole commit
with rename detection aimed at it alone, the way git blame looks for a
rename, so it is compared with the commit's deleted files and nothing
else. Doing it in cgit_diff_tree keeps the log's counts for that commit
in step with the page they link to.
The rawdiff and patch pages leave the diff to git's own output, so for
them that search finds the old name, and both names go into the limit
with rename detection on.
|
|
A LUA_PKGCONFIG that pkg-config could not resolve, with no LUA_LIBS or
LUA_CFLAGS given, still claimed to link with it and then failed on
lua.h, and a build that found no pkg-config dropped Lua with no hint
of why. A warning rather than an error lets the build go on, since
flags supplied another way, such as CGIT_LIBS in cgit.conf, may still
make it link.
|
|
The 404 page names only the repository and nothing reached the log, so
a mistyped repo.path left no trace of the path cgit had tried.
|
|
Only a scanned repository fell back to its description file, so one
listed in cgitrc without repo.desc showed "[no description]" however
its file read. repo.desc may follow repo.path, so the file is read
where a page shows the description, which also spares every other
request the reads.
|
|
atoi reads "yes" or "true" as 0, so repo.hide=yes, or cgit.hide true
in a scanned repository's git config, silently did nothing. The values
keep that meaning, since honouring them now would hide repositories on
upgrade, but each one is logged with its file and line.
|
|
A missing or unreadable cgitrc left only "No repositories found" and an
empty log, the commonest first mistake with no trace of its cause. A
scanned repository's own cgitrc stays quiet, since most have none.
|
|
"The cache" promises that a negative ttl never expires, but no age was
ever below a negative cache-scan-ttl, so every request started a
background rescan.
|
|
readdir hands entries back in whatever order the filesystem keeps
them, so proj111 could come before proj105 and a section could start
twice. section-sort is off by default to keep the order written in
cgitrc, and a scan has none to keep.
|
|
Two cgitrc files sharing a cache-root read one list, so strict-export
and trust-scan-config set in one applied to the other, and a changed
setting stayed stale until the list expired. The first request after
an upgrade scans again, and the files under the old names are never
read.
|
|
|
|
getpwuid leaves errno alone for a uid with no passwd entry, so a scan
logged "Unable to read the owner" with "Success" as the reason for each
repository such a uid owns.
|
|
exec skipped the EXIT trap, so every run left its three probe files in
TMPDIR.
|
|
|
|
|
|
|
|
Both tests passed or failed with the order in which cgit and the exec
filter happened to run, about one run in four under UBSan.
|
|
Scintillua's detect() matches an extension by its case, and the fallback
e227d1f dropped had lowercased it, so MAIN.C and SETUP.PY lost their
colour. The fake lexer now answers only for the suffixes it knows, as
Scintillua does, which is what lets the check see it.
|
|
release_revisions frees revs->mailmap, and the log page points it at the
static list cgit_mailmap returns, so every log of a repository with
enable-mailmap aborted. A walk whose setup failed holds commits that are
already freed, so releasing it could free them twice.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
|
It asks for a log page, and the index never carries a feed link.
|
|
|
|
|
|
|
|
|
|
The one-line request wrappers go with them. Configs with several
repositories, a key out of place on purpose, the cache on or no
repository of their own stay written out.
|
|
The helpers are named by kind. cgitrc_repo and cgitrc_copy write the
config file named first, and cgit_url, cgit_query and cgit_rc run cgit,
each named after what it is handed first. A repository copies its
defaults from the globals read before its repo.url, so cgitrc_repo
places every setting itself, and a global can no longer land where it
silently stops applying. The t00xx and t01xx files move to them here.
|
|
|
|
The download row was already matched on the same tag page, no fold can
sit between the message and the signature the check requires, and the
submodule row is the one the test before extracted.
|
|
bar's copies read the same page code as foo's, and the clone url row
test that follows matches bar's url in full.
|
|
t0104 checks the same span, and what it holds, on the tree and blame
pages, and t0502 checks it on a highlighted page.
|
|
t0004 reads only the documents, and t0005 builds its own repository
and configs, so each run of either built five repositories for none.
|
|
|
|
A lazy prerequisite is checked only when a test asks for it, and
test-lib names the missing one on every skipped test, so the skip
notes go too. test-lib already defines UNZIP and the unzip it checks.
The test that unpacks a tag's tar.gz with gzip now asks for GZIP like
every other one that does.
|
|
|
|
|
|
Nothing sets NO_TIDY_WARNINGS, and a warning never fails the check, so
the knob only quieted the output of a verbose run.
|
|
test_done ends the script on every path, skip_all included.
|
|
|