AgeCommit message (Collapse)AuthorLines
Blame the previous revision under its own nameBryce Kwon-4/+27
Lead a blame page's folder crumbs to the treeBryce Kwon-2/+33
Link snapshots of a slash ref by a dashed nameBryce Kwon-6/+49
The snapshot page refuses to work a revision out of a name holding a slash, since that name becomes the top directory of the archive, so every link for a ref like release/2.0 answered 404. The ref now goes in the link as the id, and the archive unpacks into the repository's own prefix, as any snapshot asked for by id does.
Show a renamed file's diff as the renameBryce Kwon-11/+191
A diff limited to the new name cannot see the old one, so the diffstat's link for a renamed file, the commit page reached from that file's log, and the file's rawdiff and patch all showed every line as added. A path the old tree lacks is now diffed across the whole commit with rename detection aimed at it alone, the way git blame looks for a rename, so it is compared with the commit's deleted files and nothing else. Doing it in cgit_diff_tree keeps the log's counts for that commit in step with the page they link to. The rawdiff and patch pages leave the diff to git's own output, so for them that search finds the old name, and both names go into the limit with rename detection on.
Say why the build leaves out Lua and what to doBryce Kwon-1/+15
A LUA_PKGCONFIG that pkg-config could not resolve, with no LUA_LIBS or LUA_CFLAGS given, still claimed to link with it and then failed on lua.h, and a build that found no pkg-config dropped Lua with no hint of why. A warning rather than an error lets the build go on, since flags supplied another way, such as CGIT_LIBS in cgit.conf, may still make it link.
Log the path of a repository that will not openBryce Kwon-1/+26
The 404 page names only the repository and nothing reached the log, so a mistyped repo.path left no trace of the path cgit had tried.
Read the description file without repo.descBryce Kwon-19/+71
Only a scanned repository fell back to its description file, so one listed in cgitrc without repo.desc showed "[no description]" however its file read. repo.desc may follow repo.path, so the file is read where a page shows the description, which also spares every other request the reads.
Report a word where cgitrc expects a numberBryce Kwon-70/+172
atoi reads "yes" or "true" as 0, so repo.hide=yes, or cgit.hide true in a scanned repository's git config, silently did nothing. The values keep that meaning, since honouring them now would hide repositories on upgrade, but each one is logged with its file and line.
Report a cgitrc or include that cannot be readBryce Kwon-6/+70
A missing or unreadable cgitrc left only "No repositories found" and an empty log, the commonest first mistake with no trace of its cause. A scanned repository's own cgitrc stays quiet, since most have none.
Keep a scan with a negative ttl for goodBryce Kwon-3/+27
"The cache" promises that a negative ttl never expires, but no age was ever below a negative cache-scan-ttl, so every request started a background rescan.
List scanned repositories in path orderBryce Kwon-8/+49
readdir hands entries back in whatever order the filesystem keeps them, so proj111 could come before proj105 and a section could start twice. section-sort is off by default to keep the order written in cgitrc, and a scan has none to keep.
Key the cached scan on every setting it usesBryce Kwon-11/+83
Two cgitrc files sharing a cache-root read one list, so strict-export and trust-scan-config set in one applied to the other, and a changed setting stayed stale until the list expired. The first request after an upgrade scans again, and the files under the old names are never read.
Release v2.11.1 v2.11.1Bryce Kwon-1/+27
Log an owner lookup only when it failsBryce Kwon-2/+6
getpwuid leaves errno alone for a uid with no passwd entry, so a scan logged "Unable to read the owner" with "Success" as the reason for each repository such a uid owns.
Let the release build clean up its probesBryce Kwon-1/+1
exec skipped the EXIT trap, so every run left its three probe files in TMPDIR.
Probe and build with the same compilerBryce Kwon-2/+7
Drain the about filter in the config testsBryce Kwon-2/+6
Reset the repository title before reusing itBryce Kwon-1/+3
Check only what the racy filter tests can promiseBryce Kwon-3/+7
Both tests passed or failed with the order in which cgit and the exec filter happened to run, about one run in four under UBSan.
Find a capitalised extension's lexer againBryce Kwon-7/+16
Scintillua's detect() matches an extension by its case, and the fallback e227d1f dropped had lowercased it, so MAIN.C and SETUP.PY lost their colour. The fake lexer now answers only for the suffixes it knows, as Scintillua does, which is what lets the check see it.
Release only finished walks, never cgit's mailmapBryce Kwon-4/+4
release_revisions frees revs->mailmap, and the log page points it at the static list cgit_mailmap returns, so every log of a repository with enable-mailmap aborted. A walk whose setup failed holds commits that are already freed, so releasing it could free them twice.
Release v2.11.0 v2.11.0Bryce Kwon-1/+96
Name every page max-blob-size coversBryce Kwon-3/+5
Spell CSS and JavaScript as cgitrc doesBryce Kwon-4/+4
Use the sanitizers the compiler offersBryce Kwon-5/+21
Probe the release build's linker flags tooBryce Kwon-4/+18
Fetch and check git with what the system hasBryce Kwon-5/+16
Find Lua under the BSDs' package namesBryce Kwon-1/+4
Test a lock won after its file became the slotBryce Kwon-1/+29
Spell side-by-side in the test commentsBryce Kwon-3/+3
Write the remaining config copies with cgitrc_copyBryce Kwon-12/+3
Move the feed link check in with the feed testsBryce Kwon-6/+6
It asks for a log page, and the index never carries a feed link.
Look for the old and new lines in one loopBryce Kwon-11/+4
Write the diff and patch checks as the suite doesBryce Kwon-29/+29
Drop the check for a language breakdown long goneBryce Kwon-4/+0
Ask for a url through cgit_url everywhereBryce Kwon-19/+19
Move the later tests to the config writersBryce Kwon-320/+182
The one-line request wrappers go with them. Configs with several repositories, a key out of place on purpose, the cache on or no repository of their own stay written out.
Add the shared config writers and cgit_rcBryce Kwon-275/+188
The helpers are named by kind. cgitrc_repo and cgitrc_copy write the config file named first, and cgit_url, cgit_query and cgit_rc run cgit, each named after what it is handed first. A repository copies its defaults from the globals read before its repo.url, so cgitrc_repo places every setting itself, and a global can no longer land where it silently stops applying. The t00xx and t01xx files move to them here.
Show the column fixture's commits like the othersBryce Kwon-1/+1
Drop test lines that repeat what came beforeBryce Kwon-6/+2
The download row was already matched on the same tag page, no fold can sit between the message and the signature the check requires, and the submodule row is the one the test before extracted.
Check a summary's branch, tags and clone url onceBryce Kwon-5/+0
bar's copies read the same page code as foo's, and the clone url row test that follows matches bar's url in full.
Leave the escape hook check to the tree testsBryce Kwon-11/+4
t0104 checks the same span, and what it holds, on the tree and blame pages, and t0502 checks it on a highlighted page.
Skip the shared fixtures where nothing reads themBryce Kwon-0/+2
t0004 reads only the documents, and t0005 builds its own repository and configs, so each run of either built five repositories for none.
Write the snapshot header and content checks onceBryce Kwon-21/+19
Leave snapshot and feed tool checks to test-libBryce Kwon-22/+5
A lazy prerequisite is checked only when a test asks for it, and test-lib names the missing one on every skipped test, so the skip notes go too. test-lib already defines UNZIP and the unzip it checks. The test that unpacks a tag's tar.gz with gzip now asks for GZIP like every other one that does.
Cut test comments restating the code beside themBryce Kwon-6/+1
Correct the test comments that went staleBryce Kwon-10/+10
Trim the tidy check down to what it doesBryce Kwon-17/+3
Nothing sets NO_TIDY_WARNINGS, and a warning never fails the check, so the knob only quieted the output of a verbose run.
Drop the exit lines that follow test_doneBryce Kwon-6/+0
test_done ends the script on every path, skip_all included.
Describe a negative section-from-path in cgitrcBryce Kwon-2/+3