Age	Commit message (Collapse)	Author	Lines
18 hours	Serve both readme escaping checks from one config	Bryce Kwon	-16/+9
18 hours	Ask each page that sorts odd branches in one loop	Bryce Kwon	-23/+8
18 hours	Write the test filter scripts with write_script	Bryce Kwon	-9/+3
18 hours	Derive the API test's config from the loud one	Bryce Kwon	-6/+1
18 hours	Check the filter flush on the pages already fetched	Bryce Kwon	-16/+7
	The about check already finds the div right before the filtered text, so its copy went, and the tree page is flattened where it was first read.
18 hours	Cut test comments that repeat what is said nearby	Bryce Kwon	-13/+4
18 hours	Correct two test comments that went stale	Bryce Kwon	-3/+3
18 hours	Drop test lines that add nothing	Bryce Kwon	-4/+0
	The trash directory starts empty and setup.sh already made the cache, the clamp check already fails on a short query, and the commit the setup named is still there to pin.
18 hours	Leave two log checks to the log tests	Bryce Kwon	-12/+0
	t0103 already renders foo/log and finds commit 5, and its search for a bracket fails the same way this literal search did if --fixed-strings ever goes.
18 hours	Leave the blob size refusals to the limits tests	Bryce Kwon	-22/+5
	t0204 asks the tree, plain, blob and blame pages for one oversized blob and checks the exact status and message, so the looser copy here went.
18 hours	Drop the hidden form fields' unused page argument	Bryce Kwon	-6/+6
18 hours	Leave the log's history simplification to git	Bryce Kwon	-1/+0
18 hours	Spell the version banner cgit	Bryce Kwon	-1/+1
18 hours	Build a literal pathspec in one place	Bryce Kwon	-62/+35
	Git's pathspec item holds a const string now, so a path needs no writable copy to be matched.
18 hours	Look up a request's commit in one place	Bryce Kwon	-88/+66
	The diff page now names a revision that is no commit the way the request wrote it, as the other pages already did, rather than as the full id it resolved to. The helpers sit beside the error page in ui-shared.c, since shared.c prints nothing.
18 hours	Count the log's columns in ui-log.c alone	Bryce Kwon	-22/+21
18 hours	Spell the signature suffix once for both files	Bryce Kwon	-4/+5
18 hours	Drop ui-blob's constant file_only arguments	Bryce Kwon	-13/+13
18 hours	Keep a commit's encoding local to its parser	Bryce Kwon	-11/+11
18 hours	Keep the query string parser beside its one caller	Bryce Kwon	-19/+17
18 hours	Drop cgit_read_first_line's unread size output	Bryce Kwon	-9/+5
18 hours	Write the repository list's description link inline	Bryce Kwon	-24/+4
18 hours	Return nothing from html_include	Bryce Kwon	-15/+4
	No caller reads the result, and a void html_include fits the Lua binding's callback as it is, so the wrapper that dropped it goes too.
18 hours	Open and close each page through the layout calls	Bryce Kwon	-51/+37
18 hours	Sort with git's QSORT	Bryce Kwon	-21/+9
	QSORT skips a list of fewer than two entries, so an empty list's null base never reaches qsort, which is what cgit_qsort was written for.
18 hours	Allocate formatted strings with git's xstrfmt	Bryce Kwon	-30/+15
18 hours	Spell non-zero the way the tree does	Bryce Kwon	-3/+3
18 hours	Say the highlighter needs Scintillua's detect()	Bryce Kwon	-2/+3
18 hours	Reuse the ids t0109 has already looked up	Bryce Kwon	-2/+0
18 hours	Drop the patch greps the comparisons already make	Bryce Kwon	-20/+0
	The From, Date, Subject and signature lines are part of what the next test compares in full against git format-patch, for the single commit and for the range alike.
18 hours	Put the valgrind comment above the loop it explains	Bryce Kwon	-3/+3
18 hours	Drop two setup.sh lines that change nothing	Bryce Kwon	-5/+3
	The library has read TEST_RESULTS_SAN_DIR for the last time by the time it returns, and the trash directory it makes is empty, so there is no cache to remove.
18 hours	Tighten the checks that match stray text	Bryce Kwon	-8/+8
	Every page holds foo in its footer element, the foo+bar row holds bar, the branch switcher holds master, and commit 1 and file-1 also match commits 10 to 19 and file-10 to file-19. A search page repeats its term in the search box. So these checks passed on pages that lacked what they look for, and each now matches the link itself.
18 hours	Require a whole page when a filter exits early	Bryce Kwon	-2/+3
	When a filter cannot run, cgit dies mid-page with its Status line already out, so the check passed with no filter at all. That is the case wherever true lives only in /bin, as on busybox. true now comes from the PATH, and the page has to reach its end.
18 hours	Make the main cgitrc filter check run the filter	Bryce Kwon	-3/+6
	The check asked for the summary page, which never runs an about filter, so it passed with exec:/bin/true on macOS, which has no such file, and with a filter that does not exist at all. Its first line read the stderr the previous test left behind. execvp searches the PATH, so a plain true runs the same on macOS, Debian and busybox.
18 hours	Let go of a slot lock that cannot take its key	Bryce Kwon	-0/+18
	A failed truncate or key write returned with the descriptor still open, so the lock was held while the page rendered uncached and the file was left behind. It is removed before its last close, as every holder does.
18 hours	Keep lock contention out of the error log	Bryce Kwon	-13/+45
	process_slot logged every failure to lock, so each request that found its slot being filled left a line, while refresh_slot logged none, so an expired slot in a directory the server cannot write was served stale for good without a word. lock_slot now logs the step that failed, as the scan does, and leaves out only another request at work.
18 hours	Lock the cached repolist with flock	Bryce Kwon	-9/+42
	The slot lock has to be an flock, since an exec filter drops a record lock when it closes the stdout a fill writes through. The scan only got by with fcntl because nothing reopens its file while it runs. One kind of lock lets the two share their code, and on Linux, where the kinds never see each other, an flock on the scan's file now holds a scan off like any other.
18 hours	Open the lock files close-on-exec	Bryce Kwon	-2/+31
	Each exec filter and snapshot compressor a fill runs inherited the slot's lock descriptor beside the stdout it writes into. An flock lasts until its last copy closes and nothing waits for a process a filter leaves behind, so a fill killed before its rename could leave the slot locked, and served stale or uncached, for as long as such a process lived. The scan holds its lock across no exec and opens the same way so that the two stay alike.
18 hours	Tidy the cache test's helpers and outputs	Bryce Kwon	-24/+18
	The header's last sentence named two of the many later subjects, so it goes too. The second request's stderr is still kept, for the lock tests that come next.
18 hours	Use test_dir_is_empty for the empty cache checks	Bryce Kwon	-16/+8
	The library's check also lists whatever was left behind when it fails.
18 hours	Catch a lexer's failure in one place	Bryce Kwon	-12/+9
	filter_close already runs highlight under pcall and serves the escaped text when it fails, so the pcalls around detect, load and lex inside it only turned a raise into the same fallback a step earlier.
18 hours	Write a session's expiry in whole seconds	Bryce Kwon	-0/+21
	On Lua 5.3 and later a length worked out with a fraction, such as 1.5 * 24 * 60 * 60, is a float, so the signed expiry came out as 1793609024.0, which validate_value refuses, and every login failed. Max-Age took the same .0, which makes a browser ignore it.
18 hours	Drop an auth prerequisite no test asks for	Bryce Kwon	-4/+2
18 hours	Set the Lua prerequisite once for every test	Bryce Kwon	-87/+27
	setup.sh already asks the binary, so the seven scripts that each turned the answer into a prerequisite now share one. test-lib names the missing prerequisite beside every test it skips, so the notes that cgit lacks Lua go, while the ones announcing a fallback stay. The list of standalone interpreters moves into lib.sh and matches the versions the extensions claim directly.
18 hours	Move the highlighter fallback check into t0502	Bryce Kwon	-24/+12
	t0502 owns the shipped highlighter and already writes a cgitrc naming it, so the check needs no config of its own there. t0204's header still called it the last case long after it stopped being one.
18 hours	Share the request helpers in the auth checks	Bryce Kwon	-77/+49
	The two identical posts for an unknown user become one, and no two checks share a name, so a failure report points at a single check.
18 hours	Let an unmirrored sink fail the way Lua would	Bryce Kwon	-12/+0
18 hours	Drop the auth stubs no check reaches	Bryce Kwon	-20/+6
	Every check replaces get_secret, the only caller of posix.sys.stat, link and unlink, and nothing outside the harness calls preload.
18 hours	Collect an email filter's writes like the others	Bryce Kwon	-10/+12