AgeCommit message (Collapse)AuthorLines
Stop robots.txt blocking files named blameBryce Kwon-2/+2
Without the trailing slash the rules also matched any path segment that starts with blame or snapshot, such as /repo/tree/blame.c. Every link cgit makes to the two pages ends the name with a slash.
Point the install notes at distribution packagesBryce Kwon-72/+81
Debian, Ubuntu, Fedora and Alpine package luaossl, luaposix and lpeg for the Lua versions they ship, which leaves LuaRocks for the rest. Scintillua comes as a release zip whose lexers directory is what the filter looks for, so its steps say where to put that.
Name a missing Lua module in the error logBryce Kwon-10/+47
Log failed loginsBryce Kwon-0/+21
The login posts outside any repository, so the log line names the repository by the page its signed way back leads to.
Say that logging in needs httpsBryce Kwon-5/+30
Only HTTPS=on counts, the same test cgit makes before it writes an https link of its own.
Tell a signed-in visitor they have no accessBryce Kwon-0/+19
Say when logins are unavailableBryce Kwon-15/+78
The way back was signed part way through the form, so while the secret's directory did not exist, or a library was missing, cgit's error landed inside the hidden input and the page broke off there with no fields.
Keep counting across a split ordered listBryce Kwon-1/+15
Say the auth filters match a repository's urlBryce Kwon-14/+25
A list keyed on the name the index shows matched nothing, so the repository it meant to protect stayed public.
Say where an edited auth filter belongsBryce Kwon-2/+17
make install copies every filter into the filters directory with mode 0644, so an edited auth-inline.lua there lost its lists on the next install, which turned every protected repository public, and until then showed its password hashes to every local user.
Mark changed lines in forced coloursBryce Kwon-0/+6
Forced colours drop the side-by-side diff's backgrounds, so an added, deleted or changed line looked like context. A thicker left border on each side that holds the line marks it, and its column still tells old from new.
Wrap long names on phonesBryce Kwon-0/+19
A ref label, email address or path longer than a phone screen pushed main.content sideways by up to 340px. In the log and summary the label also widened the shared table until the age column left the screen. Below 640px a label becomes an inline-block capped at its cell, so it still moves to the next line whole and breaks inside only when it is wider than the cell. line-height: normal keeps the box the height of the inline label it replaces. That holds exactly in Chromium and Firefox, while WebKit's box grows by a third of a pixel at each edge. Commit details and diffstat paths break at the cell edge, as listing cells already do.
Keep listing dates on one lineBryce Kwon-1/+2
A date in a listing that is not a relative age is a time element with no age class, so it missed the nowrap the ages get. Wherever a listing ran short of room the date split at its hyphen, 2026- over 02-13, and doubled every row. That happened on phones in every engine, and at 768px in Chromium and WebKit.
Keep the login page out of search indexesBryce Kwon-3/+20
Keep a protected repository's header to itselfBryce Kwon-3/+35
The login page stands in for any page of the repository, so it named the description and owner of one the visitor may not see, including one hidden from the index. The site's own description fills the line, as on the index, so the header keeps its height.
Name the logo after the siteBryce Kwon-1/+12
Head the tag table's column for what it holdsBryce Kwon-2/+17
Say when a log search matches nothingBryce Kwon-0/+15
Answer a submodule path with the submoduleBryce Kwon-14/+52
The tree page read the gitlink's commit as a blob, which outside the repository is a bad object id and inside it is the commit's raw text.
Say when nothing matches a mistyped urlBryce Kwon-1/+34
Lead an error page's title with the errorBryce Kwon-5/+21
The config error page had a title of its own, in the reverse order, and now takes the same one as any other 404, since its message already says the repository failed to open.
Keep the range in a large diff's patch linkBryce Kwon-6/+25
The link named only id, so for a diff between two commits it led to a patch of the newer one alone, and without an id it lost the branch as well and led to the default branch's tip.
Offer blame only where it worksBryce Kwon-4/+66
The blame page answers 404 for a symlink, since git blames a regular file alone, and it refuses a binary file and one past max-blob-size, yet a tree listing offered blame for all of them, and so did a symlink's own page. Each row already knows its size, and git calls a file binary by its first 8000 bytes alone, which a stream reads without inflating the rest. With blame on, a listing of 2,000 delta-packed files went from about 11 to 15 ms.
Dump only the first 64 KB of a binary fileBryce Kwon-9/+38
Blame the previous revision under its own nameBryce Kwon-4/+27
Lead a blame page's folder crumbs to the treeBryce Kwon-2/+33
Link snapshots of a slash ref by a dashed nameBryce Kwon-6/+49
The snapshot page refuses to work a revision out of a name holding a slash, since that name becomes the top directory of the archive, so every link for a ref like release/2.0 answered 404. The ref now goes in the link as the id, and the archive unpacks into the repository's own prefix, as any snapshot asked for by id does.
Show a renamed file's diff as the renameBryce Kwon-11/+191
A diff limited to the new name cannot see the old one, so the diffstat's link for a renamed file, the commit page reached from that file's log, and the file's rawdiff and patch all showed every line as added. A path the old tree lacks is now diffed across the whole commit with rename detection aimed at it alone, the way git blame looks for a rename, so it is compared with the commit's deleted files and nothing else. Doing it in cgit_diff_tree keeps the log's counts for that commit in step with the page they link to. The rawdiff and patch pages leave the diff to git's own output, so for them that search finds the old name, and both names go into the limit with rename detection on.
Say why the build leaves out Lua and what to doBryce Kwon-1/+15
A LUA_PKGCONFIG that pkg-config could not resolve, with no LUA_LIBS or LUA_CFLAGS given, still claimed to link with it and then failed on lua.h, and a build that found no pkg-config dropped Lua with no hint of why. A warning rather than an error lets the build go on, since flags supplied another way, such as CGIT_LIBS in cgit.conf, may still make it link.
Log the path of a repository that will not openBryce Kwon-1/+26
The 404 page names only the repository and nothing reached the log, so a mistyped repo.path left no trace of the path cgit had tried.
Read the description file without repo.descBryce Kwon-19/+71
Only a scanned repository fell back to its description file, so one listed in cgitrc without repo.desc showed "[no description]" however its file read. repo.desc may follow repo.path, so the file is read where a page shows the description, which also spares every other request the reads.
Report a word where cgitrc expects a numberBryce Kwon-70/+172
atoi reads "yes" or "true" as 0, so repo.hide=yes, or cgit.hide true in a scanned repository's git config, silently did nothing. The values keep that meaning, since honouring them now would hide repositories on upgrade, but each one is logged with its file and line.
Report a cgitrc or include that cannot be readBryce Kwon-6/+70
A missing or unreadable cgitrc left only "No repositories found" and an empty log, the commonest first mistake with no trace of its cause. A scanned repository's own cgitrc stays quiet, since most have none.
Keep a scan with a negative ttl for goodBryce Kwon-3/+27
"The cache" promises that a negative ttl never expires, but no age was ever below a negative cache-scan-ttl, so every request started a background rescan.
List scanned repositories in path orderBryce Kwon-8/+49
readdir hands entries back in whatever order the filesystem keeps them, so proj111 could come before proj105 and a section could start twice. section-sort is off by default to keep the order written in cgitrc, and a scan has none to keep.
Key the cached scan on every setting it usesBryce Kwon-11/+83
Two cgitrc files sharing a cache-root read one list, so strict-export and trust-scan-config set in one applied to the other, and a changed setting stayed stale until the list expired. The first request after an upgrade scans again, and the files under the old names are never read.
Release v2.11.1 v2.11.1Bryce Kwon-1/+27
Log an owner lookup only when it failsBryce Kwon-2/+6
getpwuid leaves errno alone for a uid with no passwd entry, so a scan logged "Unable to read the owner" with "Success" as the reason for each repository such a uid owns.
Let the release build clean up its probesBryce Kwon-1/+1
exec skipped the EXIT trap, so every run left its three probe files in TMPDIR.
Probe and build with the same compilerBryce Kwon-2/+7
Drain the about filter in the config testsBryce Kwon-2/+6
Reset the repository title before reusing itBryce Kwon-1/+3
Check only what the racy filter tests can promiseBryce Kwon-3/+7
Both tests passed or failed with the order in which cgit and the exec filter happened to run, about one run in four under UBSan.
Find a capitalised extension's lexer againBryce Kwon-7/+16
Scintillua's detect() matches an extension by its case, and the fallback e227d1f dropped had lowercased it, so MAIN.C and SETUP.PY lost their colour. The fake lexer now answers only for the suffixes it knows, as Scintillua does, which is what lets the check see it.
Release only finished walks, never cgit's mailmapBryce Kwon-4/+4
release_revisions frees revs->mailmap, and the log page points it at the static list cgit_mailmap returns, so every log of a repository with enable-mailmap aborted. A walk whose setup failed holds commits that are already freed, so releasing it could free them twice.
Release v2.11.0 v2.11.0Bryce Kwon-1/+96
Name every page max-blob-size coversBryce Kwon-3/+5
Spell CSS and JavaScript as cgitrc doesBryce Kwon-4/+4
Use the sanitizers the compiler offersBryce Kwon-5/+21
Probe the release build's linker flags tooBryce Kwon-4/+18