Diff options
authorBryce Kwon <bryce@brycekwon.com>
committerBryce Kwon <bryce@brycekwon.com>
commit
parent
tree
download
Trim the build script comments
The release script described a -Wformat-nonliteral run it does not make, and the development script's header retold the flags below it.
Diffstat (limited to 'tools/build-release.sh')
-rwxr-xr-xtools/build-release.sh9
1 file changed, 1 insertion, 8 deletions
diff --git a/tools/build-release.sh b/tools/build-release.sh
index ade979c..00fa089 100755
--- a/tools/build-release.sh
+++ b/tools/build-release.sh
@@ -27,7 +27,6 @@ lua)
;;
esac
-# Every make target below is written relative to the repository root.
cd "$(dirname "$0")/.."
CC=${CC:-cc}
@@ -75,13 +74,7 @@ LDFLAGS="-pie -Wl,-z,relro,-z,now -Wl,-z,noexecstack"
# These reach only the cgit objects, so git's own sources are not held to them.
# -Wformat-security is an error because a non-literal format with no arguments
-# is never intentional. -Wformat-nonliteral would catch the module-link shape,
-# a non-literal that does take arguments, but it also fires on va_list
-# forwarding and on local format constants, so it is left to manual runs when
-# touching anything that formats.
-#
-# make cgit CGIT_EXTRA_CFLAGS=-Wformat-nonliteral
-#
+# is never intentional.
CGIT_EXTRA_CFLAGS="-Wformat -Wformat-security -Werror=format-security"
# The build starts from clean so the bundled git objects pick up the same