Diff options
authorBryce Kwon <bryce@brycekwon.com>
committerBryce Kwon <bryce@brycekwon.com>
commit
parent
tree
download
Release only finished walks, never cgit's mailmap
release_revisions frees revs->mailmap, and the log page points it at the static list cgit_mailmap returns, so every log of a repository with enable-mailmap aborted. A walk whose setup failed holds commits that are already freed, so releasing it could free them twice.
Diffstat (limited to '')
-rw-r--r--source/ui-stats.c1
1 file changed, 0 insertions, 1 deletion
diff --git a/source/ui-stats.c b/source/ui-stats.c
index f3ad25e..ee5b76b 100644
--- a/source/ui-stats.c
+++ b/source/ui-stats.c
@@ -218,7 +218,6 @@ static int collect_stats(const struct cgit_period *period, struct string_list *a
// bounds the period edge exactly.
rev.max_age = since;
if (cgit_prepare_walk(&rev)) {
- release_revisions(&rev);
strvec_clear(&argv);
return -1;
}