Diff options
| author | Bryce Kwon <bryce@brycekwon.com> | |
|---|---|---|
| committer | Bryce Kwon <bryce@brycekwon.com> | |
| commit | ||
| parent | ||
| tree | ||
| download | ||
Release only finished walks, never cgit's mailmap
release_revisions frees revs->mailmap, and the log page points it at the
static list cgit_mailmap returns, so every log of a repository with
enable-mailmap aborted. A walk whose setup failed holds commits that are
already freed, so releasing it could free them twice.
Diffstat (limited to '')
| -rw-r--r-- | source/ui-patch.c | 1 |
1 file changed, 0 insertions, 1 deletion
diff --git a/source/ui-patch.c b/source/ui-patch.c index 3c76255..0fa9a2e 100644 --- a/source/ui-patch.c +++ b/source/ui-patch.c @@ -74,7 +74,6 @@ void cgit_print_patch(const char *new_rev, const char *old_rev, const char *pref rev.max_count = ctx.cfg.max_patch_count; // The headers wait until the walk has started. if (cgit_prepare_walk(&rev)) { - release_revisions(&rev); strvec_clear(&rev_argv); return; } |