Diff options
| author | Bryce Kwon <bryce@brycekwon.com> | |
|---|---|---|
| committer | Bryce Kwon <bryce@brycekwon.com> | |
| commit | ||
| parent | ||
| tree | ||
| download | ||
Tolerate a missing or empty repository URL
trim_end() returns NULL when a repo url is empty or all slashes, and the
later newline trim dereferenced it. The legacy r= and p=about path also
read the last byte of the url without checking it was set.
Diffstat (limited to 'source/shared.c')
| -rw-r--r-- | source/shared.c | 3 |
1 file changed, 2 insertions, 1 deletion
diff --git a/source/shared.c b/source/shared.c index a39394d..c509aa1 100644 --- a/source/shared.c +++ b/source/shared.c @@ -52,7 +52,8 @@ struct cgit_repo *cgit_add_repo(const char *url) ret = &cgit_repolist.repos[cgit_repolist.count-1]; memset(ret, 0, sizeof(struct cgit_repo)); ret->url = trim_end(url, '/'); - *strchrnul(ret->url, '\n') = '\0'; + if (ret->url) + *strchrnul(ret->url, '\n') = '\0'; ret->name = ret->url; ret->path = NULL; ret->desc = cgit_default_repo_desc; |