Diff options
| author | Bryce Kwon <bryce@brycekwon.com> | |
|---|---|---|
| committer | Bryce Kwon <bryce@brycekwon.com> | |
| commit | ||
| parent | ||
| tree | ||
| download | ||
Mark avatar icons as decorative
A screen reader announced the service's name before every author.
Diffstat (limited to 'custom/extensions/email-gravatar.lua')
| -rw-r--r-- | custom/extensions/email-gravatar.lua | 7 |
1 file changed, 3 insertions, 4 deletions
diff --git a/custom/extensions/email-gravatar.lua b/custom/extensions/email-gravatar.lua index eca31ee..d5c30fc 100644 --- a/custom/extensions/email-gravatar.lua +++ b/custom/extensions/email-gravatar.lua @@ -42,7 +42,6 @@ local has_digest, digest = pcall(require, "openssl.digest") local avatar_size = 13 local default_image = "retro" local base_url = "https://www.gravatar.com/avatar/" -local alt_text = "Gravatar" -- One name reaches this filter as an open, writes and a close, so what the @@ -111,7 +110,8 @@ end -- A log page can carry one icon per commit, so the attributes let the -- browser defer the fetches for icons still off screen and keep decoding --- off the critical path. +-- off the critical path. The icon only decorates the name beside it, so its +-- alt text is empty and a screen reader goes straight to the name. function filter_close() if avatar_hash == nil then html(buffer) @@ -119,8 +119,7 @@ function filter_close() html("<img src='" .. base_url .. avatar_hash .. "?s=" .. avatar_size .. "&d=" .. default_image .. - "' alt='" .. alt_text .. - "' width='" .. avatar_size .. + "' alt='' width='" .. avatar_size .. "' height='" .. avatar_size .. "' loading='lazy' decoding='async'> " .. buffer) end |