Diff options
| author | John Keeping <john@keeping.me.uk> | |
|---|---|---|
| committer | Jason A. Donenfeld <Jason@zx2c4.com> | |
| commit | ||
| parent | ||
| tree | ||
| download | ||
Always #include corresponding .h in .c files
While doing this, remove declarations from header files where the
corresponding definition is declared "static" in order to avoid build
errors.
Also re-order existing headers in ui-*.c so that the file-specific
header always comes immediately after "cgit.h", helping with future
consistency.
Signed-off-by: John Keeping <john@keeping.me.uk>
| -rw-r--r-- | html.c | 1 | |
| -rw-r--r-- | html.h | 2 | |
| -rw-r--r-- | scan-tree.c | 1 | |
| -rw-r--r-- | ui-atom.c | 1 | |
| -rw-r--r-- | ui-blob.c | 1 | |
| -rw-r--r-- | ui-clone.c | 1 | |
| -rw-r--r-- | ui-commit.c | 1 | |
| -rw-r--r-- | ui-diff.c | 1 | |
| -rw-r--r-- | ui-diff.h | 3 | |
| -rw-r--r-- | ui-log.c | 1 | |
| -rw-r--r-- | ui-patch.c | 1 | |
| -rw-r--r-- | ui-plain.c | 1 | |
| -rw-r--r-- | ui-refs.c | 1 | |
| -rw-r--r-- | ui-repolist.c | 1 | |
| -rw-r--r-- | ui-shared.c | 1 | |
| -rw-r--r-- | ui-shared.h | 2 | |
| -rw-r--r-- | ui-snapshot.c | 1 | |
| -rw-r--r-- | ui-ssdiff.c | 2 | |
| -rw-r--r-- | ui-stats.c | 2 | |
| -rw-r--r-- | ui-summary.c | 1 | |
| -rw-r--r-- | ui-tag.c | 1 | |
| -rw-r--r-- | ui-tree.c | 1 |
22 files changed, 20 insertions, 8 deletions
@@ -6,6 +6,7 @@ * (see COPYING for full license text) */ +#include "html.h" #include <unistd.h> #include <stdio.h> #include <stdlib.h> @@ -1,7 +1,7 @@ #ifndef HTML_H #define HTML_H -extern int htmlfd; +#include <stddef.h> extern void html_raw(const char *txt, size_t size); extern void html(const char *txt); diff --git a/scan-tree.c b/scan-tree.c index 10d90f4..0d3e0ad 100644 --- a/scan-tree.c +++ b/scan-tree.c @@ -8,6 +8,7 @@ */ #include "cgit.h" +#include "scan-tree.h" #include "configfile.h" #include "html.h" @@ -7,6 +7,7 @@ */ #include "cgit.h" +#include "ui-atom.h" #include "html.h" #include "ui-shared.h" @@ -8,6 +8,7 @@ */ #include "cgit.h" +#include "ui-blob.h" #include "html.h" #include "ui-shared.h" @@ -8,6 +8,7 @@ */ #include "cgit.h" +#include "ui-clone.h" #include "html.h" #include "ui-shared.h" diff --git a/ui-commit.c b/ui-commit.c index 5a552a1..8310ce6 100644 --- a/ui-commit.c +++ b/ui-commit.c @@ -7,6 +7,7 @@ */ #include "cgit.h" +#include "ui-commit.h" #include "html.h" #include "ui-shared.h" #include "ui-diff.h" @@ -7,6 +7,7 @@ */ #include "cgit.h" +#include "ui-diff.h" #include "html.h" #include "ui-shared.h" #include "ui-ssdiff.h" @@ -3,9 +3,6 @@ extern void cgit_print_diff_ctrls(); -extern void cgit_print_diffstat(const unsigned char *old_sha1, - const unsigned char *new_sha1); - extern void cgit_print_diff(const char *new_hex, const char *old_hex, const char *prefix, int show_ctrls); @@ -7,6 +7,7 @@ */ #include "cgit.h" +#include "ui-log.h" #include "html.h" #include "ui-shared.h" #include "vector.h" @@ -7,6 +7,7 @@ */ #include "cgit.h" +#include "ui-patch.h" #include "html.h" #include "ui-shared.h" @@ -8,6 +8,7 @@ #include <stdio.h> #include "cgit.h" +#include "ui-plain.h" #include "html.h" #include "ui-shared.h" @@ -7,6 +7,7 @@ */ #include "cgit.h" +#include "ui-refs.h" #include "html.h" #include "ui-shared.h" diff --git a/ui-repolist.c b/ui-repolist.c index a9751f6..76fe71a 100644 --- a/ui-repolist.c +++ b/ui-repolist.c @@ -8,6 +8,7 @@ */ #include "cgit.h" +#include "ui-repolist.h" #include "html.h" #include "ui-shared.h" #include <strings.h> diff --git a/ui-shared.c b/ui-shared.c index 7a726c1..945d560 100644 --- a/ui-shared.c +++ b/ui-shared.c @@ -7,6 +7,7 @@ */ #include "cgit.h" +#include "ui-shared.h" #include "cmd.h" #include "html.h" diff --git a/ui-shared.h b/ui-shared.h index 0666388..5f8b629 100644 --- a/ui-shared.h +++ b/ui-shared.h @@ -47,8 +47,6 @@ extern void cgit_diff_link(const char *name, const char *title, extern void cgit_stats_link(const char *name, const char *title, const char *class, const char *head, const char *path); -extern void cgit_self_link(char *name, const char *title, - const char *class, struct cgit_context *ctx); extern void cgit_object_link(struct object *obj); extern void cgit_submodule_link(const char *class, char *path, diff --git a/ui-snapshot.c b/ui-snapshot.c index e199a92..9be5dbe 100644 --- a/ui-snapshot.c +++ b/ui-snapshot.c @@ -8,6 +8,7 @@ */ #include "cgit.h" +#include "ui-snapshot.h" #include "html.h" #include "ui-shared.h" diff --git a/ui-ssdiff.c b/ui-ssdiff.c index 3d3dad6..cbe60bd 100644 --- a/ui-ssdiff.c +++ b/ui-ssdiff.c @@ -1,8 +1,8 @@ #include "cgit.h" +#include "ui-ssdiff.h" #include "html.h" #include "ui-shared.h" #include "ui-diff.h" -#include "ui-ssdiff.h" extern int use_ssdiff; @@ -1,7 +1,7 @@ #include "cgit.h" +#include "ui-stats.h" #include "html.h" #include "ui-shared.h" -#include "ui-stats.h" #ifdef NO_C99_FORMAT #define SZ_FMT "%u" diff --git a/ui-summary.c b/ui-summary.c index 0754bb7..bd123ef 100644 --- a/ui-summary.c +++ b/ui-summary.c @@ -8,6 +8,7 @@ */ #include "cgit.h" +#include "ui-summary.h" #include "html.h" #include "ui-log.h" #include "ui-refs.h" @@ -7,6 +7,7 @@ */ #include "cgit.h" +#include "ui-tag.h" #include "html.h" #include "ui-shared.h" |